From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 7/7] Remove unnecessary Qunbound check Date: Thu, 25 Mar 2021 12:46:23 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 17:57:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPTID-00085r-BC for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 17:57:09 +0100 Original-Received: from localhost ([::1]:48196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPTIC-0005vl-A0 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 12:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPT84-0007oc-FY for emacs-devel@gnu.org; Thu, 25 Mar 2021 12:46:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPT7s-0003S4-1f; Thu, 25 Mar 2021 12:46:39 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 42735440FB6; Thu, 25 Mar 2021 12:46:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 05747440FA0; Thu, 25 Mar 2021 12:46:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616690785; bh=kyxyMeFoopg0VHAmGKuuAVlvTMYEi0o1/Xlr7JtaxQg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oU413+2SAiBnshiJJ3J1D18XMhKOtNSwrBck9lqjeAlKJkuWeM6sNqaKHqEr0RnZL Aq4RKuy3MbcfekWe4cNZ1HOqZ9o6vserYdFc9i3t/JkKTvVtuAaB5iGJCOcfhPvsFM 0e/9PBnJcfBQ41VzQ9w0XgIDLtC3VfvoHBqR7otOa/NGPWAuiokeXmLm5ipGSqsScu Cy9Nvdooam/HfRPis/IbKZu1NBP3VnBIUUMXqgaBcYdyrwuBEYXNjFpBZKvPRjBoDu zlY88HAuy/2xYuHe9aU3WQMFTe5BI3Lij2VpYMNwuRVEJ+Kd75DMJ/MP63afjW75r/ 7vKlOkbuNmJfA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 50929120255; Thu, 25 Mar 2021 12:46:24 -0400 (EDT) In-Reply-To: (Spencer Baugh's message of "Tue, 23 Mar 2021 23:11:57 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267034 Archived-At: > DEFVAR_PER_BUFFER variables (which this function deals with) cannot be > Qunbound, at least right now; they're either set to a value, or > PER_BUFFER_VALUE_P is false. Are you sure? What if you do something like `(makunbound 'buffer-file-coding-system)`? The other 6 patches look good to me. Stefan