From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: vertico Date: Sat, 10 Apr 2021 09:34:35 -0400 Message-ID: References: <87im4vglwv.fsf@gnu.org> <87sg3y7g7x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38531"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Tassilo Horn To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 10 15:35:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVDm8-0009v3-Py for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 15:35:48 +0200 Original-Received: from localhost ([::1]:43318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVDm7-0004MB-Sm for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 09:35:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVDl5-0003wd-1w for emacs-devel@gnu.org; Sat, 10 Apr 2021 09:34:43 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVDl2-0007IG-IY; Sat, 10 Apr 2021 09:34:42 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E67DA80658; Sat, 10 Apr 2021 09:34:38 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 46585801F1; Sat, 10 Apr 2021 09:34:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1618061677; bh=erzX+JJV5QAUoJdta231zGqCbOIgamWpZoECjF5Vp3s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WQv4qzBD3d6/187mTfvmME4/zV8lou2Wz1KiuMbrVJG5FAnE3JthknSxVH4TeRNiB zdOHv4GmkBRjGBv9tPdnQOO1vNpIoruQk/UW64NXEZ2FfgzN76GoLdHnK1Qip8/J23 4dvaB744g3yT7M2XA3T3Mm4d5jy0wRp7Hi1I2FBYp7w7osrZ78o2dctHVsS+i/DYLr McI3X2gZRBTZB6De40emrGcJd+0N5PTFt06PVc0EM2xtaD6z/wX3IkfG5B+iRGxH/5 l+fQHPfgNlWmEo/pZNjwybrIoylv7UZZlC60Ao5RZzDgty/y1O+OIc6DBuDIOlzGZc I0+cSQQNEc3Bw== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CCDD412040E; Sat, 10 Apr 2021 09:34:36 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Sat, 10 Apr 2021 11:33:32 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267819 Archived-At: > If you bind `minibuffer-complete` to a keybinding in `vertico-map` it will > automatically update the UI via the `post-command-hook`, which calls > `vertico--exhibit`. > > I have checked your aggressive-completion package and there you are using > a timer. I wonder why you are doing that (Performance issues?). Wouldn't it > be better to use an `after-change-function` or a `post-command-hook`? If you Maybe a way to handle it "right" is for vertico to register an `after-change-function` so as to detect also when the buffer's content is modified outside of the normal commands (i.e. from a timer or process filter). It'd probably be a bit messy, tho: it wouldn't want to refresh the completion list right away, but there's no "obvious" later hook to use (like `post-command-hook`) so it would need to detect when there's not going to be a subsequent post-command-hook (i.e. when we're in a timer or similar) and then probably fire its own timer to update the completion list when the current processing is done. Or maybe it should use `after-change-function` to detect changes and `pre-redisplay-functions` to update the list of completion. Stefan