From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: cc-mode fontification feels random Date: Sat, 12 Jun 2021 11:46:56 -0400 Message-ID: References: <179f6e4fa40.2816.cc5b3318d7e9908e2c46732289705cb0@dancol.org> <83fsxpbpn9.fsf@gnu.org> <83k0n09tkp.fsf@gnu.org> <837dj09p0e.fsf@gnu.org> <20210611232535.b4dyu3a2yxvdixys@Ergus> <87a6nw6jtf.fsf@telefonica.net> <20210612010844.45noqsg7wveeo3yw@Ergus> <83sg1n8t71.fsf@gnu.org> <83bl8b88qz.fsf@gnu.org> <83a6nv86m3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: spacibba@aol.com, ofv@wanadoo.es, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 12 17:48:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ls5sN-0000S5-JV for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Jun 2021 17:48:47 +0200 Original-Received: from localhost ([::1]:34156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ls5sM-0007Uy-LF for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Jun 2021 11:48:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ls5qm-0005rD-K4 for emacs-devel@gnu.org; Sat, 12 Jun 2021 11:47:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ls5qi-0007aX-20; Sat, 12 Jun 2021 11:47:06 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E790C8088B; Sat, 12 Jun 2021 11:46:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8267680695; Sat, 12 Jun 2021 11:46:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1623512817; bh=Xz+46QfXo1KdOd5YaOIdsYH02XdfEn2RYysYy6e9/uw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZuaGgJUJlx85aizN22krcIQOrZ+tQ8LW+4VRL9QOIWQId5/57NhLpZcbX6XgE46IL hSozFBp/ePgJZ1mEJ3PpT0fswfxS46Dxpi1CsEb1+HRMDWmeHISrp0rdPqP9w+E3VI Q1n/f55w4kds2/leg/Nq57Jejq4yyQeUpE6Bdz/9L+RP60WpYOrz41NMzUeCa03dBV Ajr4e3jKo+N45L5Rex0QZr5XNBlIVifHJY9bwfwke7hkJLQKTgJjJomIgvZ8MeaLs+ iWFDBiRLxnXjPZuf1imubX8ULyNLR8J1MaeU/OL+8w9aEcAy9Uu18TJYvnQHIKyI5t hQ0gnSilik8IA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 39D0B1202BB; Sat, 12 Jun 2021 11:46:57 -0400 (EDT) In-Reply-To: <83a6nv86m3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Jun 2021 18:06:44 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270771 Archived-At: > I've seen that, but it's full of FIXMEs that basically tell me this is > incomplete and perhaps even kludgey? I haven't looked in detail at how it works, but w.r.t its interaction with font-lock and jit-lock it seems sane. > I don't really understand why the workarounds are needed (nor why > font-lock-keywords would need to still be supported with TS). `font-lock-keywords` is (ab)used by several other packages, like hi-lock, so a major mode that uses font-lock but sets it up in a way that ignores `font-lock-keywords` introduces problems. Maybe instead of overriding `font-lock-fontify-region-function` it would be better to use a single entry in `font-lock-keywords` which calls something like `tree-sitter-hl--highlight-region`, but these are minor details that don't affect the general approach. > And I cannot say I'm happy with the uses of buffer-substring and the > many conversions between character positions and byte positions. > Maybe these could be cleaned up? I'm pretty sure the code (and the authors) would welcome help making it cleaner, yes. Stefan