From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 859190f 2/3: Convert some keymaps to defvar-keymap Date: Thu, 14 Oct 2021 16:59:55 -0400 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <87h7dm9en7.fsf@gnus.org> <818f9907c2b1fe8b54b1@heytings.org> <83tuhlnkxm.fsf@gnu.org> <818f9907c2f359a71f49@heytings.org> <83czo9nj4g.fsf@gnu.org> <818f9907c244b9db0bea@heytings.org> <834k9lnd2i.fsf@gnu.org> <818f9907c2dff3b49971@heytings.org> <83k0ign3zj.fsf@gnu.org> <818f9907c26fb6f0233a@heytings.org> <838rywm7a7.fsf@gnu.org> <9865db3af5547c6ca15c@heytings.org> <9865db3af561bf9f05d1@heytings.org> <87mtnbv2q1.fsf@gnus.org> <87h7djv0j4.fsf@gnus.org> <87czo7uyxl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , Gregory Heytings , Eli Zaretskii , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 14 23:03:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb7tA-0006gD-72 for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 23:03:44 +0200 Original-Received: from localhost ([::1]:34628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb7t8-0002aE-EB for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 17:03:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb7qZ-0007wU-7e for emacs-devel@gnu.org; Thu, 14 Oct 2021 17:01:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb7qV-0003vz-OK; Thu, 14 Oct 2021 17:01:01 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 806181002E3; Thu, 14 Oct 2021 17:00:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9DEAF10012E; Thu, 14 Oct 2021 17:00:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634245254; bh=x4NQ154LKb6FVKi0/bbXCfc3O14NiV9y9sJyGnWg8QI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YnQ3ZjXP/k0A2kL9sTO5x4k+98XuKxegVigyEzi89tshUcu4v1z4/0bLYHZ/XlRgX KXhw7sYPsvcOM/AcPzSB2snoChbZojX/kGG3T9ciw9QZ8+JUOlc0igBKwXmmUEgLOu EqhislQEWRuo21Czox6YJjj79mTqB0qyJXInbhBTeIzvFI+buEfqT/QeExUfZ45L6L btxHMxINLC5JUYmDW51KYGqbwwHp37bO/DIoZGi29sopfrBgn8anshxNehMp8NnMqf Rrx/4rmkanKK7sV+VDrtV+SRQ1eiHqCUea6zehRocfphOUXTXcNELaYNsT7Hkyw2et wMVSQbWlCUZfA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8BE0E12020A; Thu, 14 Oct 2021 17:00:54 -0400 (EDT) In-Reply-To: <87czo7uyxl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 14 Oct 2021 22:35:50 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277062 Archived-At: > (define-key map [tab] 'todo-next-button) > > Hm, the kbd syntax would be > > (define-key map [TAB] 'todo-next-button) > > but I guess it's fine... No, the `kbd` syntax for `tab` is "". > (define-key function-key-map [C-delete] [?\M-d]) > That's C- in kbd syntax -- I guess it's fine if we accept both, > but then we lose the opportunity to be stricter with the syntax. I guess we could also accept `C-`, but I think it would be better to catch it and signal an error. > Oh, yeah, I had totally forgotten that this is how menus are defined. > To it's ambiguous here -- the thing in [] could be anything, including > [s], which kdb would interpret as the key "s". This area of Emacs is tricky enough that we may encounter surprises, but I think using [?s] for such a menu entry "key binding" would work just fine, currently. > This form is limited to menu items, though, so perhaps it could be made > to work (i.e., if the DEF is a menu item, then we have different logic). I'd rather not go there. Stefan