From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Indentation of def* Date: Fri, 15 Oct 2021 09:17:47 -0400 Message-ID: References: <878ryw1ptl.fsf@gnus.org> <871r4nn9ty.fsf@yahoo.com> <87ilxzzwn1.fsf@gnus.org> <878ryvzw7s.fsf@gnus.org> <87h7djlskn.fsf@yahoo.com> <87v91zyfiy.fsf@gnus.org> <87wnmfkd7p.fsf@yahoo.com> <87bl3rka3n.fsf@yahoo.com> <877defjhqr.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35017"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Po Lu , Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 15:21:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbN9J-0008sA-1E for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 15:21:25 +0200 Original-Received: from localhost ([::1]:56898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbN9H-0006aa-JP for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 09:21:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbN5w-0002IJ-CZ for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:17:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbN5t-0002YN-7R for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:17:55 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3F10A440B04; Fri, 15 Oct 2021 09:17:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AF940440A5E; Fri, 15 Oct 2021 09:17:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634303868; bh=Cc6UDFiQWG0A1t9zipU0UpBpanRFPOwnRrTqYb1lrrI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XE+GvNtr5PazGTmIsrh0wzQGSw51v+F7X7vjg7UTkLymvRERdDVIOD6IwR4DXWq+2 7/B7OLPdsnR0WV0cS4CP0xB6DH1xSM5K7ZltXDEntfDAU54s8+cUy0V7QD4roPWf6k dCcVJcWGD7PQm4NyD3duIiewpg3b9gmWiEVLuLcxX1pH1k790HCInzHTYSRZoiyuYM JcGLmVDPgenbmRipf+uo3H3VxjpWsivmuP5Tof32dV5ZtizI5AKsY8nvpAAQvzCFQq rRMR+lNnIOpPWkC06AJv5jHeVHmqsl+bWRv55u4QtipYuAt6OGBIjST76V4t0UMT8T /dVR72vUN/4rw== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3E98712037B; Fri, 15 Oct 2021 09:17:48 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Thu, 14 Oct 2021 17:50:18 -0700") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277119 Archived-At: Stefan Kangas [2021-10-14 17:50:18] wrote: > Po Lu writes: >> That would be a step backwards, at least without a grace period for all >> the code out there to adjust. > I don't think it's a bad idea to announce this change as planned for > Emacs 29.1 in the Emacs 28.1 NEWS file. You mean something like: ** Deprecate ad-hoc indentation rule for functions/macros named def* All macros and functions which expect to be indented similarly to `defun` should use something like (declare (indent defun)) instead. ? We could, but I think the more important change is to make it concrete with changes in the behavior. In order to make the change more gradual, here are some ideas: - Let font-lock put an ugly color on those cases that would be affected by the rule change. - Emit a warning every time we use the ad-hoc def* rule during indentation (could even be made fancy, e.g. accompany the warning with a button that jumps to the definition and adds the missing (declare (indent defun))). - Make the change conditional on a variable, so that users can easily recover the previous behavior until the missing `declare` is added. Could be a boolean var, or a var containing a list of offenders. Stefan