From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Loading tramp for dump goes into infinite regress Date: Mon, 25 Jul 2022 12:54:47 -0400 Message-ID: References: <8735erhrlg.fsf@gmx.de> <83wnc2g0n8.fsf@gnu.org> <83sfmqfxcb.fsf@gnu.org> <83a68yfp6j.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , michael.albinus@gmx.de, emacs-devel To: Lynn Winebarger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 25 18:55:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oG1My-0004ys-Po for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jul 2022 18:55:48 +0200 Original-Received: from localhost ([::1]:40052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oG1Mx-0006Km-9P for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Jul 2022 12:55:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG1M8-0005UL-2f for emacs-devel@gnu.org; Mon, 25 Jul 2022 12:54:56 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:55314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG1M5-000295-5x; Mon, 25 Jul 2022 12:54:55 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B96771002D5; Mon, 25 Jul 2022 12:54:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0B88110016E; Mon, 25 Jul 2022 12:54:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658768089; bh=TdYP0YISve9P8G3Q2GkzqhxiQ/j+94ypp+AJz3a1YM0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=d++stYaXUqPfaC8r8AxYG+SbgydS24CDbV5whhfx5swqAZk4+a61icI8E2G3+kcvc BvQxaZruL5qyUPGbcZhfyZ1/ve6t1nZV9kSf0IDgzU2b0BppE2ifoWH8mF2fMRQOJt +hAT0Xm6yMU0dLDzkBGwg8+MoYVrhZ9HTOb1TXh4pBnCCuIYCCbSelfoLejdFsOxmx V+cZOyJjZ97rPfaPEYSxerokWQR1Pvwm5QL7LZRqNHcvJl8o3MV4Kzz9pwEZK9w6SR unhb5fKeZ/gPPn+oM0gINr9ZXSmVMkDdgomjcCx535nDKLlH+5KFk04f0JIUqU7eTV CDhGwr+ob8C8w== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C701D12037A; Mon, 25 Jul 2022 12:54:48 -0400 (EDT) In-Reply-To: (Lynn Winebarger's message of "Mon, 25 Jul 2022 08:49:27 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292642 Archived-At: > Otherwise, I was able to resolve the various issues (including some > extensive surgery on vc/ediff-X files to stamp out the circular loading). > I am going to have to do a real bootstrap to avoid the "incoherent eln" > error, though, and somehow force native compilation for all the libraries > loaded in the dump (that are not on the compiler's "forbidden" list, > anyway). BTW, I don't really understand why you're bumping into circularity issue with things like ediff. I do know it has circularity issues, but they only affect compilation, AFAIK. So, I'm wondering: do you include "the world" in both dumps (the first, done to build `src/bootstrap-emacs.pdmp`, and the second to build the final `src/emacs.pdmp`) or do you include it only in the second dump? Looking at `lisp/loadup.el`, it seems that the normal way is to dump `site-load.el` in both cases, but that would indeed introduce more difficulties than needed: we should only load `site-load.el` during the second dump, so the bootstrap itself is not affected. IOW, my crystal ball suggests you try the patch below. Stefan diff --git a/lisp/loadup.el b/lisp/loadup.el index 21a87dbd77b..63c5bc2adec 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -387,15 +386,16 @@ ;; you may load them with a "site-load.el" file. ;; But you must also cause them to be scanned when the DOC file ;; is generated. -(let ((lp load-path)) - (load "site-load" t) - ;; We reset load-path after dumping. - ;; For a permanent change in load-path, use configure's - ;; --enable-locallisppath option. - ;; See https://debbugs.gnu.org/16107 for more details. - (or (equal lp load-path) - (message "Warning: Change in load-path due to site-load will be \ -lost after dumping"))) +(unless (member dump-mode '("bootstrap" "pbootstrap")) + (let ((lp load-path)) + (load "site-load" t) + ;; We reset load-path after dumping. + ;; For a permanent change in load-path, use configure's + ;; --enable-locallisppath option. + ;; See https://debbugs.gnu.org/16107 for more details. + (or (equal lp load-path) + (message "Warning: Change in load-path due to site-load will be \ +lost after dumping")))) ;; Used by `kill-buffer', for instance. (load "emacs-lisp/rmc")