From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 11:16:17 -0400 Message-ID: References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16696"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Alfred M. Szmidt" , eliz@gnu.org, larsi@gnus.org, juri@jurta.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 17:18:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT30B-00041d-Hj for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 17:18:07 +0200 Original-Received: from localhost ([::1]:37732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT30A-0008FW-Jl for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 11:18:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT2yd-00079c-7s for emacs-devel@gnu.org; Tue, 30 Aug 2022 11:16:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT2yZ-00078F-Ho; Tue, 30 Aug 2022 11:16:30 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BB850804AB; Tue, 30 Aug 2022 11:16:24 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 74EF580413; Tue, 30 Aug 2022 11:16:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661872583; bh=u2wpMc49abZFtWO6ZJpaY2cK141AsQaO7BMrlz5L9Qw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=n55kIjIpcRrpZP2Sw0981csUSofasLstJfrHtFfyZAuIrEN3UZjUKI4Mar/Bd3A5R NYLaQAjA+u6on21X5CX5fdIqLazC/RiIMLNVSiPWkjjGxk1vjmL0eg5jxP9sHkftBK ICF2SE2z9osMCO5m3H1MZOTHYHk+SPGt8sLCSoJ6GCVfcBMjCXSaLiPDmXhKAzYhCc mCL5n7DSqmJgOV26gOOK1Tih8yZ8m9ZpXVQGtu+JBuKs0fDI1muVQkaaKC2k6O9piN iUtfmVIuuqFywS2lkyxN39aDSlcRvEOhwcha4eKpT6uMOiOcaE+Or32Bas2zyoX+FN k3HPfRjAVxnhA== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3E221120663; Tue, 30 Aug 2022 11:16:23 -0400 (EDT) In-Reply-To: (Dmitry Gutov's message of "Tue, 30 Aug 2022 17:38:27 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294350 Archived-At: > I can look into adapting this approach for other VCS if nobody beats me to > it. As long as we fundamentally agree on the behavior. Fine by me. I'll just mention that I think we should be careful to make sure no info is lost if Emacs crashes in the middle of the operation. Stefan