From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
arstoffel@gmail.com, orontee@gmail.com, emacs-devel@gnu.org
Subject: Re: Tree-sitter integration in python.el
Date: Wed, 12 Oct 2022 13:52:15 -0400 [thread overview]
Message-ID: <jwvwn95kk9v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <F6727429-0EBB-4539-8486-E8BA169956B7@gmail.com> (Yuan Fu's message of "Tue, 11 Oct 2022 22:04:38 -0700")
> One problem I can see is that the same level could give very different
> busyness across modes. That would defeat the purpose of having a single
> setting. Say mode 1 has (A B C D E F G H I), where ABC are very basic, DEF
> moderate, and GHI fancy, mode 2 has (A B C D E F G), A basic, BCDEF
> moderate, G fancy. Then 80 would give a fancy font-lock in mode 1 and
> a moderate font-lock in mode 2. You get the idea.
Yup. We could be more explicit, then, e.g. use things like ((A B C) (D
E F) (G H I)) for the first and ((A) (B C D E F) (G)) for the second.
> Currently tree-sitter supports both :level and :toggle. When defining
> queries you can say :toggle python-fontify-types, and python-fontify-types
> can control this query. :level would be the global rough settings, :toggle
> would be the local, fine-grained setting. Instead of variables, :toggle
> could be changed to use symbols as you suggested, so it doesn’t create
> a gazillion variables. But WDYT of the general design?
I definitely prefer symbols to variables: this way they can use their
own namespace and don't need the long package prefix and can be
shared/reused between different modes without conflict.
And I would prefer not to include :level in the rules themselves and
instead rely on a separate mapping between features and levels.
Stefan
next prev parent reply other threads:[~2022-10-12 17:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 18:42 Tree-sitter integration in python.el Yuan Fu
2022-09-26 19:10 ` Jostein Kjønigsen
2022-09-27 22:16 ` Yuan Fu
2022-10-03 18:07 ` Matthias Meulien
2022-10-03 18:38 ` Eli Zaretskii
2022-10-03 22:19 ` Matthias Meulien
2022-10-03 22:31 ` Yuan Fu
2022-10-03 22:47 ` Matthias Meulien
2022-10-06 2:56 ` Yuan Fu
2022-10-06 7:18 ` Matthias Meulien
2022-10-06 18:26 ` Yuan Fu
2022-10-06 20:53 ` Matthias Meulien
2022-10-07 8:25 ` Yuan Fu
2022-10-07 10:03 ` Augusto Stoffel
2022-10-07 17:53 ` chad
2022-10-07 19:09 ` Eli Zaretskii
2022-10-07 22:17 ` Yuan Fu
2022-10-07 22:10 ` Yuan Fu
2022-10-08 6:30 ` Eli Zaretskii
2022-10-08 20:57 ` Yuan Fu
2022-10-09 4:13 ` Eli Zaretskii
2022-10-11 22:15 ` Stefan Monnier
2022-10-12 5:04 ` Yuan Fu
2022-10-12 17:52 ` Stefan Monnier [this message]
2022-10-12 22:55 ` Yuan Fu
2022-10-12 23:43 ` Yuan Fu
2022-10-13 0:16 ` [SPAM UNSURE] " Stephen Leake
2022-10-13 5:55 ` Eli Zaretskii
2022-10-15 23:15 ` Yuan Fu
2022-10-08 8:03 ` Augusto Stoffel
2022-10-08 16:20 ` [External] : " Drew Adams
2022-10-10 15:38 ` Augusto Stoffel
2022-10-08 21:06 ` Yuan Fu
2022-10-10 7:16 ` Augusto Stoffel
2022-10-10 15:10 ` Yuan Fu
2022-10-10 15:53 ` Augusto Stoffel
2022-10-12 5:08 ` Yuan Fu
2022-10-11 22:18 ` Stefan Monnier
2022-10-04 6:13 ` Eli Zaretskii
2022-10-04 11:21 ` Matthias Meulien
2022-10-04 12:33 ` Eli Zaretskii
2022-10-04 17:11 ` Matthias Meulien
2022-10-03 22:25 ` Yuan Fu
2022-10-16 7:31 ` Eli Zaretskii
2022-10-16 8:15 ` Yuan Fu
2022-10-16 8:18 ` Eli Zaretskii
2022-10-03 22:35 ` Matthias Meulien
-- strict thread matches above, loose matches on Subject: below --
2022-10-03 21:53 lkg.ch@pm.me
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwn95kk9v.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=arstoffel@gmail.com \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=orontee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).