From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Wrong dependency headers for Ement v0.4 Date: Mon, 24 Oct 2022 16:51:39 -0400 Message-ID: References: <85sfjfa7v0.fsf@elpa.gnu.org> <75b04605-f880-cfd3-3ee2-48603e741fab@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 24 23:08:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1on4gR-0005YL-Vr for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Oct 2022 23:08:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1on4QI-0000vF-PE; Mon, 24 Oct 2022 16:51:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1on4QH-0000v4-DB for emacs-devel@gnu.org; Mon, 24 Oct 2022 16:51:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1on4QF-0008Su-DZ for emacs-devel@gnu.org; Mon, 24 Oct 2022 16:51:49 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 79608100123; Mon, 24 Oct 2022 16:51:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9C71410001C; Mon, 24 Oct 2022 16:51:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666644703; bh=Gb4lc+fhy+wS6wPzjBZJHxr8r1W+4f/Ml8LCo7o6fg0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XTE2nF6CXwmT2R38Q2z5n6ltA9RhmgYGoDYW88a5ZL84RZPuHDtcPULjoWxZSf9Tk iDFM8iUGY5UPG73pZIX2tccH/wuMzD5qCbawX5Z2PhpOXkwTZxsU3rTeDxZaEf61MK 6fIFH/Y3iosCit/tVWhVV3RRxFJ+C7B5pdNdkhONoV1A4I5O4sMWUbYG0jBbufSmMS oWZ4hJMjsoqOcg3BZ13L8BP0MEoZLA5iUcvdVqo0D7IEL218kYDfTBsWFMEq1bhDTJ ByY/1dQVQZpkA8GFs/xWOLeL6SkR9IfkDcSBNq/LB7n4qEBD3p4yNAnq31oyDPfDiW cLk+glq7WM/QQ== Original-Received: from alfajor (modemcable219.124-130-66.mc.videotron.ca [66.130.124.219]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 49D591201A4; Mon, 24 Oct 2022 16:51:43 -0400 (EDT) In-Reply-To: <75b04605-f880-cfd3-3ee2-48603e741fab@alphapapa.net> (Adam Porter's message of "Mon, 24 Oct 2022 10:44:59 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298424 Archived-At: > I've encountered a strange situation: I recently published v0.4 of Ement. > The describe-package command now shows this: > > Package ement is incompatible. > > Status: Incompatible because it depends on uninstallable packages. > Archive: gnu > Version: 0.4 > Commit: b06c78d1ba700857330520bc796c5a29018b7ec5 > Summary: Matrix client > Requires: emacs-27.1, map-2.1, plz-0.2, taxy-0.12.1 (not available), > taxy-magit-section-0.9, svg-lib-0.2.5, transient-0.3.7 > Website: https://github.com/alphapapa/ement.el > > However, these package headers do not match those in the listed commit, > i.e. https://github.com/alphapapa/ement.el/blob/b06c78d1ba700857330520bc796c5a29018b7ec5/ement.el > shows: Hmm... this seems to clearly point to a bug in `elpa-admin.el`. I wonder how we end up generating a `ement-pkg.el` that contains this Git revision id, with a `0.4` version, the correct files, but the wrong set of requires. [... reading the code...] Hmm... it looks like we get most of the metadata for `-pkg.el` from the HEAD before we select the actual revision from which we'll build the tarball :-( This is ugly. It probably messed up several existing tarballs, actually (just in a way sufficiently "harmless" that noone complained loudly enough yet). > Aside: This is one way in which MELPA is a bit easier to work with: although > MELPA Stable is generally not recommended for use (due to various issues), > it builds packages from version tags rather than git master (regular MELPA > builds from git master); if ELPA worked the same way, I could easily tag > a v0.4.1 independently of what's on the master branch. We can actually do something similar currently by adding a `:version-map` in the `elpa-packages` spec to make a release from an arbitrary Git commit (it's better avoided but was introduced to handle cases where the upstream doesn't have any `Version:` header, as well as to allow building a new tarball with a different version number in case the original build was broken for some reason, as in our case). > Given that, would it be possible to have ELPA build from a separate branch? > That's how I organize some of my other packages, with a "stable" branch and > a master branch. If ELPA pulled from a "stable" branch, I could push a fix > to that while the next major version is still in development. We can also do that, yes, using the `:release-branch`. Stefan