From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: Allowing rolling release packages on ELPA
Date: Wed, 26 Oct 2022 14:55:13 -0400 [thread overview]
Message-ID: <jwvwn8m5sc2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87czaev3lc.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 26 Oct 2022 18:31:43 +0000")
> How does this look like:
LGTM, thanks.
[ We may want to refine this later, e.g. to avoid the resulting
redundancy between GNU and GNU-devel, but I'm not sure yet what we'll
want to do it about it, so let's see how it works first. ]
Stefan
> From 6f746b919d3a377cf8ef0f9aa34ebbf9969b0188 Mon Sep 17 00:00:00 2001
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Sun, 16 Oct 2022 18:05:40 +0200
> Subject: [PATCH] Add support for rolling-release packages
>
> * README: Document :rolling-release
> * elpa-admin.el (elpaa--get-release-revision): Respect
> :rolling-release.
> (elpaa--make-one-package): Respect :rolling-release.
> ---
> README | 11 ++++++++++-
> elpa-admin.el | 10 +++++++++-
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/README b/README
> index 4ff305047a..1c42f13cd7 100644
> --- a/README
> +++ b/README
> @@ -1,5 +1,5 @@
> #+TITLE: ELPA-Admin README
> -#+DATE: 2022-01-06
> +#+DATE: 2022-10-26
>
> Copyright (C) 2010-2022 Free Software Foundation, Inc. \\
> See the end of the file for license conditions.
> @@ -168,6 +168,15 @@ this ORIG-VERSION (or REMAPPED-VERSION if non-nil) to override
> the default heuristic which uses the last revision that modified the
> "Version:" header.
>
> +** =:rolling-release FLAG=
> +If FLAG is non-nil, a new package will be released for every new
> +commit, instead of just on incrementing the "Version" header. FLAG
> +can optionally be a string, in which case the package is only released
> +if the version is equal to FLAG.
> +
> +Note that the usage of this option is discouraged. Only use it if the
> +package maintainer explicitly wishes to use a "rolling release" model.
> +
> * Configuration (elpa-config)
>
> The configuration file is a `lisp-data-mode` file containing
> diff --git a/elpa-admin.el b/elpa-admin.el
> index a1eec9c448..7ed78430d6 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -194,6 +194,7 @@ commit which modified the \"Version:\" pseudo header."
> (not (member vers (car version-map))))
> (pop version-map))
> (or (nth 2 (car version-map))
> + (and (elpaa--spec-get pkg-spec :rolling-release) "HEAD")
> ;; When the mainfile is a symlink (e.g. for :core packages), run Git
> ;; in the directory that holds the actual file, otherwise Git won't
> ;; know what file we're talking about.
> @@ -945,7 +946,8 @@ place the resulting tarball into the file named TARBALL-ONLY."
> dir pkg-spec
> `(nil ,devel-vers
> . ,(nthcdr 2 metadata))
> - nil tarball-only))))
> + nil tarball-only)))
> + (rolling-release (elpaa--spec-get pkg-spec :rolling-release)))
>
> ;; Try and build the latest release tarball.
> (cond
> @@ -972,7 +974,13 @@ place the resulting tarball into the file named TARBALL-ONLY."
> tarball dir pkg-spec metadata
> (lambda () (cdr last-rel)))
> (elpaa--release-email pkg-spec metadata dir)))))))
> + ((and (stringp rolling-release)
> + (not (version= rolling-release vers)))
> + (elpaa--message "Expected version %s, but got %s for package %s!"
> + rolling-release vers pkgname))
> (t
> + (when rolling-release
> + (setq vers devel-vers))
> (let ((tarball (concat elpaa--release-subdir
> (format "%s-%s.tar" pkgname vers))))
> (when (elpaa--make-one-tarball
next prev parent reply other threads:[~2022-10-26 18:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 10:31 Allowing rolling release packages on ELPA Philip Kaludercic
2022-10-23 4:47 ` Protesilaos Stavrou
2022-10-23 8:43 ` Philip Kaludercic
2022-10-24 6:14 ` Bozhidar Batsov
2022-10-24 6:45 ` Jostein Kjønigsen
2022-10-24 8:07 ` Bozhidar Batsov
2022-10-24 14:06 ` Stefan Kangas
2022-10-26 19:18 ` Richard Stallman
2022-10-24 16:00 ` Philip Kaludercic
2022-10-24 16:39 ` Jostein Kjønigsen
2022-10-26 19:18 ` Richard Stallman
2022-10-24 19:27 ` Stefan Monnier
2022-10-24 15:58 ` Philip Kaludercic
2022-10-24 17:27 ` Stephen Leake
2022-10-24 19:40 ` Stefan Monnier
2022-10-26 6:32 ` Philip Kaludercic
2022-10-26 11:57 ` Stefan Monnier
2022-10-26 15:27 ` Philip Kaludercic
2022-10-26 18:31 ` Philip Kaludercic
2022-10-26 18:55 ` Stefan Monnier [this message]
2022-10-26 19:07 ` Philip Kaludercic
2022-10-25 20:14 ` Richard Stallman
2022-10-26 5:10 ` Bozhidar Batsov
2022-10-26 6:30 ` Philip Kaludercic
2022-10-26 8:05 ` Bozhidar Batsov
2022-10-26 19:18 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2022-10-26 5:58 Payas Relekar
2022-10-26 8:07 ` Bozhidar Batsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwn8m5sc2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).