From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Luke Lee <luke.yx.lee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes
Date: Sun, 29 Jan 2023 22:01:23 -0500 [thread overview]
Message-ID: <jwvwn54afsl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv8rhkbuz9.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 29 Jan 2023 21:50:17 -0500")
[ Resending with a better email address. ]
> (eval-when-compile
> - (require 'cl-lib)
> + (if (version< emacs-version "27.0")
> + (progn
> + (require 'cl) ;; Package cl is deprecated for Emacs27+
> + (require 'cl-macs))
> + (require 'cl-lib))
This looks like a regression resulting from a misunderstanding.
What are you trying to do here?
The rest of the code uses only `cl-lib` functionality, so (require 'cl)
will be useful only if it internally does (require 'cl-lib).
In Emacs<24.3, this will fail because (require 'cl) will not define the
macros that the rest of the code needs (e.g. `cl-eval-when`, `cl-loop`, ...).
Stefan
next prev parent reply other threads:[~2023-01-30 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167500933323.27282.16366310039274039148@vcs2.savannah.gnu.org>
[not found] ` <20230129162214.20BBEC0019D@vcs2.savannah.gnu.org>
2023-01-30 2:50 ` [elpa] externals/brief 362d629671: Brief mode v5.88.22 release for various enhancements and bug fixes Stefan Monnier
2023-01-30 3:01 ` Stefan Monnier [this message]
2023-01-30 16:53 ` 路客
2023-01-30 2:58 ` Stefan Monnier
2023-01-30 17:07 ` 路客
2023-01-30 17:15 ` Stefan Monnier
2023-01-31 15:12 ` 路客
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwn54afsl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=luke.yx.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).