From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master f17bdee79b1: sgml-mode.el: Cosmetic fixes
Date: Mon, 17 Jul 2023 08:57:03 -0400 [thread overview]
Message-ID: <jwvwmyy7l5w.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87leffq6ok.fsf@gmail.com> (Robert Pluim's message of "Mon, 17 Jul 2023 10:32:43 +0200")
> Stefan> diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el
> Stefan> index b4f5ebf5cd0..d80cdc34775 100644
> Stefan> --- a/lisp/textmodes/sgml-mode.el
> Stefan> +++ b/lisp/textmodes/sgml-mode.el
> Stefan> @@ -66,7 +66,7 @@ When 2, attribute indentation looks like this:
> Stefan> </element>"
> Stefan> :version "25.1"
> Stefan> :type 'integer
> Stefan> - :safe 'integerp)
> Stefan> + :safe #'integerp)
>
> Isnʼt that already enforced by the ':typeʼ keyword?
No.
> If so, we have lots of redundant ':safe' in defcustoms.
It's not redundant: one describe the set of values that are meaningful
(so as to allow Custom to provide a more helpful UI), the other
specifies which values are believed to be safe when coming from
untrusted sources.
They're closely related and often identical, but not always.
Stefan
next prev parent reply other threads:[~2023-07-17 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168943569908.27847.5147959039975518199@vcs2.savannah.gnu.org>
[not found] ` <20230715154139.5B03FC06C71@vcs2.savannah.gnu.org>
2023-07-17 8:32 ` master f17bdee79b1: sgml-mode.el: Cosmetic fixes Robert Pluim
2023-07-17 12:57 ` Stefan Monnier [this message]
2023-07-17 13:17 ` Robert Pluim
2023-07-17 13:33 ` Eli Zaretskii
2023-07-17 15:18 ` Basil Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmyy7l5w.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).