From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Tue, 30 Jan 2024 07:41:58 -0500 Message-ID: References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ihor Radchenko To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 13:42:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUnRt-0002Cq-Fp for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 13:42:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUnRQ-0007yf-PA; Tue, 30 Jan 2024 07:42:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUnRJ-0007rk-80 for emacs-devel@gnu.org; Tue, 30 Jan 2024 07:42:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUnRD-0003cI-AI for emacs-devel@gnu.org; Tue, 30 Jan 2024 07:42:06 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0129D1000DA; Tue, 30 Jan 2024 07:42:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706618520; bh=zgiTMHJoHxmESaTdBenklvUls8usqGHa9OLdH9nqHQo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CtRrMBkjoeap4vOngA2HyUOtM1UwXOGsna8KcI5yDKGH+zIWgQvEf/qyjOk09NfbL X88iv9MIOFtbgyNI+w0ZEANsDUMOcriBd1DjKZQHJ5hsJqmKx8I9N1dFGpC0VgBv9d ymw/eG7o4Q4iWxamEFM+TyR9bjQqEEOb55LFXN+lLX0RRTLoU5qtJAU9AENt/OGwYo YbWZJ7ZTUUCY3a6ubTl+TuuYVGLG8s8gzAzsRQOo326qEQlsMwAo/Bg1swL7kmU2Sf TUnpajSPwlz6xFE1142HejTm8nuvPpQl9jiEYpNef9nMNjadA8pgkVKFifKPbgsF2J a+NJ90T6z0tYA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 16565100054; Tue, 30 Jan 2024 07:42:00 -0500 (EST) Original-Received: from pastel (104-222-119-131.cpe.teksavvy.com [104.222.119.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E6CCE120D0D; Tue, 30 Jan 2024 07:41:59 -0500 (EST) In-Reply-To: <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 30 Jan 2024 07:00:55 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315635 Archived-At: > diff --git a/lisp/ox-bibtex.el b/lisp/ox-bibtex.el > index 743fd7da2a..8cdf390cf2 100644 > --- a/lisp/ox-bibtex.el > +++ b/lisp/ox-bibtex.el > @@ -157,9 +157,11 @@ to `org-bibtex-citation-p' predicate." > (defvar org-bibtex-file nil > "Org file of BibTeX entries.") > > +(declare-function obe-citations "org-bibtex-extras" ()) > (defun org-bibtex-goto-citation (&optional citation) > "Visit a citation given its ID." > (interactive) > + (require 'org-bibtex-extras) > (let ((citation (or citation (completing-read "Citation: " (obe-citations))))) > (find-file (or org-bibtex-file > (error "`org-bibtex-file' has not been configured"))) The `declare-function` should be placed right next (after) the `require`. In practice it (currently) makes no difference (because of technical details of how `declare-function` is (currently) implemented), but in theory it clarifies that you do not intend to claim that it's safe to call `obe-citations` from anywhere within `ox-bibtex`, but only from within `org-bibtex-goto-citation`. Stefan