From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Ihor Radchenko <yantar92@posteo.net>
Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require
Date: Tue, 30 Jan 2024 07:41:58 -0500 [thread overview]
Message-ID: <jwvwmrratcn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Tue, 30 Jan 2024 07:00:55 -0500 (EST)")
> diff --git a/lisp/ox-bibtex.el b/lisp/ox-bibtex.el
> index 743fd7da2a..8cdf390cf2 100644
> --- a/lisp/ox-bibtex.el
> +++ b/lisp/ox-bibtex.el
> @@ -157,9 +157,11 @@ to `org-bibtex-citation-p' predicate."
> (defvar org-bibtex-file nil
> "Org file of BibTeX entries.")
>
> +(declare-function obe-citations "org-bibtex-extras" ())
> (defun org-bibtex-goto-citation (&optional citation)
> "Visit a citation given its ID."
> (interactive)
> + (require 'org-bibtex-extras)
> (let ((citation (or citation (completing-read "Citation: " (obe-citations)))))
> (find-file (or org-bibtex-file
> (error "`org-bibtex-file' has not been configured")))
The `declare-function` should be placed right next (after) the
`require`. In practice it (currently) makes no difference (because of
technical details of how `declare-function` is (currently) implemented),
but in theory it clarifies that you do not intend to claim that it's safe
to call `obe-citations` from anywhere within `ox-bibtex`, but only from
within `org-bibtex-goto-citation`.
Stefan
next parent reply other threads:[~2024-01-30 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org>
[not found] ` <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org>
2024-01-30 12:41 ` Stefan Monnier [this message]
2024-01-30 15:19 ` [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Ihor Radchenko
2024-01-30 17:31 ` Stefan Monnier
2024-01-30 18:59 ` Ihor Radchenko
2024-01-30 21:41 ` Stefan Monnier
2024-01-30 22:11 ` Ihor Radchenko
2024-01-30 22:57 ` Stefan Monnier
2024-01-31 14:51 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmrratcn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).