From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: Markers in a gap array
Date: Thu, 04 Jul 2024 09:16:02 -0400 [thread overview]
Message-ID: <jwvwmm1e1yi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ikxlqwu6.fsf@localhost> (Ihor Radchenko's message of "Thu, 04 Jul 2024 10:24:01 +0000")
Ihor Radchenko [2024-07-04 10:24:01] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> There's no free lunch, so this comes at the cost of slowing down other
>> marker operations, which is why I'd like to hear about your experience.
>> ...
>> So, for instance, `save-excursion` used to do a `copy-marker` followed
>> by a (set-marker m nil), both of which were, typically, O(1) and are now
>> made slower.
>
> First experience - severe performance degradation compared to master.
>
> Some perf stats:
>
> ;; Switch to todo and mark next 3 times, on branch
> ;; 28.72% emacs emacs [.] markers_sanity_check
Did you build with or without assertions?
And indeed, I need to rework them to be "more conditional" (but I was
focused on correctness until now). You should probably remove those
calls to `markers_sanity_check` by hand when testing performance, sorry.
Stefan
next prev parent reply other threads:[~2024-07-04 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 4:59 Markers in a gap array Stefan Monnier
2024-07-04 10:24 ` Ihor Radchenko
2024-07-04 13:16 ` Stefan Monnier [this message]
2024-07-04 14:30 ` Ihor Radchenko
2024-07-04 20:11 ` Stefan Monnier
2024-07-04 20:34 ` Pip Cet
2024-07-04 20:42 ` Stefan Monnier
2024-07-17 16:48 ` Helmut Eller
2024-07-18 20:46 ` Stefan Monnier
2024-07-26 19:48 ` Helmut Eller
2024-08-05 19:54 ` MPS: marker-vector (was: Markers in a gap array) Helmut Eller
2024-08-05 21:14 ` MPS: marker-vector Pip Cet
2024-08-06 6:28 ` Helmut Eller
2024-08-06 6:51 ` Gerd Möllmann
2024-08-06 14:36 ` Pip Cet
2024-08-06 16:15 ` Helmut Eller
2024-08-06 3:59 ` Gerd Möllmann
2024-08-06 6:02 ` Helmut Eller
2024-07-04 22:24 ` Markers in a gap array Stefan Monnier
2024-07-07 12:31 ` Ihor Radchenko
2024-07-07 13:09 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvwmm1e1yi.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).