From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.gnus.general,gmane.emacs.devel Subject: Re: Changes in calendar/time-date.el Date: Mon, 04 Apr 2005 15:50:05 -0400 Message-ID: References: <871x9w9dkn.fsf@xs4all.nl> <87mzsezu5f.fsf@xs4all.nl> <87hdimzou0.fsf@xs4all.nl> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1112644483 17238 80.91.229.2 (4 Apr 2005 19:54:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2005 19:54:43 +0000 (UTC) Cc: Lute Kamstra , Miles Bader , ding@gnus.org, emacs-devel@gnu.org Original-X-From: ding-owner+M8615@lists.math.uh.edu Mon Apr 04 21:54:41 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by ciao.gmane.org with esmtp (Exim 4.43) id 1DIXdQ-0000Au-Ia for ding-account@gmane.org; Mon, 04 Apr 2005 21:53:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1DIXaX-00044M-00; Mon, 04 Apr 2005 14:50:21 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1DIXaT-00044H-00 for ding@lists.math.uh.edu; Mon, 04 Apr 2005 14:50:17 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1DIXaR-0008IQ-Ox for ding@lists.math.uh.edu; Mon, 04 Apr 2005 14:50:15 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1DIXaO-0002lL-00 for ; Mon, 04 Apr 2005 21:50:12 +0200 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 962CB340013; Mon, 4 Apr 2005 15:50:09 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 61A2B4AC2A5; Mon, 4 Apr 2005 15:50:05 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 4F430E6C18; Mon, 4 Apr 2005 15:50:05 -0400 (EDT) Original-To: Reiner Steib In-Reply-To: (Reiner Steib's message of "Mon, 04 Apr 2005 19:20:59 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.829, requis 5, autolearn=not spam, AWL 0.07, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Score: -4.9 (----) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:60090 gmane.emacs.devel:35560 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35560 >>> (eval-when-compile >>> (require 'cl) >>> (defvar parse-time-weekdays) ;; parse-time is required where necessary >>> (defvar parse-time-months) Why not (require 'parse-time) simply? This way if parse-time is ever changed to remove parse-time-months, the byte-compiler will correctly catch it. > `with-no-warnings' isn't available in Emacs 21. with-no-warnings should be avoided as much as possible since it can hide any warning whatsoever without justification. (defvar foo) explains to the byte-compiler (and the human reader) *why* the warning should be skipped. > (defun nnimap-date-days-ago (daysago) > "Return date, in format \"3-Aug-1998\", for DAYSAGO days ago." > + (require 'parse-time) > + (defvar parse-time-months) A (defvar foo) form only makes sense at the toplevel. Stefan