From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: featurep instead of bound tests Date: Thu, 24 Jan 2008 17:48:26 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201215980 14829 80.91.229.12 (24 Jan 2008 23:06:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2008 23:06:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 25 00:06:39 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JIB94-0000t8-59 for ged-emacs-devel@m.gmane.org; Fri, 25 Jan 2008 00:06:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIB8e-00055a-4m for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2008 18:05:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIArz-0003D3-Lu for emacs-devel@gnu.org; Thu, 24 Jan 2008 17:48:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIArx-0003BZ-Ta for emacs-devel@gnu.org; Thu, 24 Jan 2008 17:48:27 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIArx-0003BN-LT for emacs-devel@gnu.org; Thu, 24 Jan 2008 17:48:25 -0500 Original-Received: from x-132-204-254-59.xtpr.umontreal.ca ([132.204.254.59] helo=ceviche.home) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JIArx-0005h3-AE for emacs-devel@gnu.org; Thu, 24 Jan 2008 17:48:25 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 6BEB0B409A; Thu, 24 Jan 2008 17:48:26 -0500 (EST) In-Reply-To: (Reiner Steib's message of "Thu, 24 Jan 2008 22:44:37 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-Greylist: delayed 4984 seconds by postgrey-1.27 at monty-python; Thu, 24 Jan 2008 17:48:25 EST X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87456 Archived-At: >> --- gnus/ChangeLog 24 Jan 2008 07:47:37 -0000 1.633 >> +++ gnus/ChangeLog 24 Jan 2008 15:14:50 -0000 1.634 >> @@ -1,3 +1,9 @@ >> +2008-01-24 Dan Nicolaescu >> + >> + * sieve.el (sieve-make-overlay, sieve-overlay-put, sieve-overlays-at): >> + * message.el (message-beginning-of-line): Use featurep instead of bound >> + tests in order to resolve conditionals at compile time. > In the past, I've been told that it's preferable to use fbound tests > instead of Emacs flavor or version tests. So I'm surprised by changes > like these... Agreed. I see 2 better solutions: 1 - use (require 'outline) 2 - teach the byte-optimizer that (fboundp 'make-overlay) will always be t. Stefan