From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: featurep instead of bound tests
Date: Thu, 24 Jan 2008 17:48:26 -0500 [thread overview]
Message-ID: <jwvve5i96zb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <v9myquew56.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Thu, 24 Jan 2008 22:44:37 +0100")
>> --- gnus/ChangeLog 24 Jan 2008 07:47:37 -0000 1.633
>> +++ gnus/ChangeLog 24 Jan 2008 15:14:50 -0000 1.634
>> @@ -1,3 +1,9 @@
>> +2008-01-24 Dan Nicolaescu <dann@ics.uci.edu>
>> +
>> + * sieve.el (sieve-make-overlay, sieve-overlay-put, sieve-overlays-at):
>> + * message.el (message-beginning-of-line): Use featurep instead of bound
>> + tests in order to resolve conditionals at compile time.
> In the past, I've been told that it's preferable to use fbound tests
> instead of Emacs flavor or version tests. So I'm surprised by changes
> like these...
Agreed. I see 2 better solutions:
1 - use (require 'outline)
2 - teach the byte-optimizer that (fboundp 'make-overlay) will always be t.
Stefan
next prev parent reply other threads:[~2008-01-24 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1JI3n9-0003Yy-Mx@cvs.savannah.gnu.org>
2008-01-24 21:44 ` featurep instead of bound tests (was: Changes to emacs/lisp/gnus/ChangeLog, v) Reiner Steib
2008-01-24 21:55 ` Dan Nicolaescu
2008-01-24 22:48 ` Stefan Monnier [this message]
2008-01-25 5:49 ` featurep instead of bound tests Dan Nicolaescu
2008-01-25 9:45 ` Stephen J. Turnbull
2008-01-25 22:47 ` Richard Stallman
2008-01-25 22:47 ` featurep instead of bound tests (was: Changes to emacs/lisp/gnus/ChangeLog, v) Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvve5i96zb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).