unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: Word Delimited Query Replace
Date: Sat, 18 Oct 2008 15:21:58 -0400	[thread overview]
Message-ID: <jwvvdvpogwr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878wsl27pv.fsf@jurta.org> (Juri Linkov's message of "Sat, 18 Oct 2008 19:23:09 +0300")

> BTW, I discovered a UI problem: to prepare the patch it was necessary
> to rename the string "default" but not its plural form "defaults" in
> read-regexp.  So I selected the region around the body of read-regexp
> and typed `C-s default C-u M-%'.  The C-u prefix argument of query-replace
> means to replace only matches surrounded by word boundaries, but while
> implementing isearch-query-replace a few years ago we missed this case,
> so currently isearch-query-replace just ignores it.

IIUC the right way to do it is to use M-s w during the search to toggle
isearch-word, after which M-% should DTRT (just like M-% in regexp
isearch requests a query-replace-regexp).

Also, are you sure your patch works?  As far as I can tell, C-u
currently leaves isearch, and I don't see anything in your patch that
would change it.


        Stefan




  reply	other threads:[~2008-10-18 19:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-18 12:41 read-regexp Eli Zaretskii
2008-10-18 16:19 ` read-regexp Juri Linkov
2008-10-18 19:13   ` read-regexp Stefan Monnier
2008-10-18 19:55     ` read-regexp Juri Linkov
2008-10-18 21:47       ` read-regexp Stefan Monnier
2008-10-18 23:29         ` read-regexp Juri Linkov
2008-10-18 19:21   ` read-regexp Eli Zaretskii
2008-10-18 19:59     ` read-regexp Juri Linkov
2008-10-18 16:23 ` Word Delimited Query Replace (was: read-regexp) Juri Linkov
2008-10-18 19:21   ` Stefan Monnier [this message]
2008-10-18 19:52     ` Word Delimited Query Replace Juri Linkov
2008-10-18 21:37       ` Stefan Monnier
2008-10-18 23:29         ` Juri Linkov
2008-10-19  2:08           ` Stefan Monnier
2008-10-19 22:48             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvdvpogwr.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).