unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Phil Hagelberg <phil@hagelb.org>
Cc: emacs-devel@gnu.org
Subject: Re: vc-register complains if a file is already registered in a git repository
Date: Tue, 21 Oct 2008 21:37:21 -0400	[thread overview]
Message-ID: <jwvvdvlxvgc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <873aipmvt6.fsf@hagelb.org> (Phil Hagelberg's message of "Tue, 21 Oct 2008 15:23:49 -0700")

> I just noticed the existence of the vc-default-could-register function:

>   Return non-nil if BACKEND could be used to register FILE.

> It seems like vc-register should be running this function instead of
> vc-registered to check if it should continue, like this:

No, could-register is used for other purposes.

> Since we're in a feature freeze, perhaps this is ill-advised?

Yes.

>> It would probably be better for vc-git to provide another command, for that.
>> We could probably add a `extra-keys' operation similar to `extra-menu'
>> so that vc-git can not only provide a new command but also provide
>> a specific C-x v <foo> key binding for it.

> This would be great if we don't want to make the changes above. I can
> add it. Could I get some details about extra-menu though? I'm not
> familiar with it.

Grep for extra-menu and extra-status-menu (which should be renamed
extra-dir-menu, BTW) in vc*.el.


        Stefan




  reply	other threads:[~2008-10-22  1:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 20:29 vc-register complains if a file is already registered in a git repository Phil Hagelberg
2008-10-21 21:43 ` Stefan Monnier
2008-10-21 22:23   ` Phil Hagelberg
2008-10-22  1:37     ` Stefan Monnier [this message]
2008-10-28 17:21       ` Phil Hagelberg
2008-10-28 18:19         ` Phil Hagelberg
2008-10-28 22:24           ` Phil Hagelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvdvlxvgc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=phil@hagelb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).