From: "Stefan Monnier" <monnier@iro.umontreal.ca>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Please try Pmail
Date: Tue, 20 Jan 2009 21:37:49 -0500 [thread overview]
Message-ID: <jwvvds9pfi5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87eiyyvz2h.fsf@cyd.mit.edu> (Chong Yidong's message of "Tue, 20Jan 2009 09:20:38 -0500")
> /* If build_annotations switched buffers, switch back to BUF.
> Kill the temporary buffer that was selected in the meantime.
> Since this kill only the last temporary buffer, some buffers remain
> not killed if build_annotations switched buffers more than once.
> -- K.Handa */
> static Lisp_Object
> build_annotations_unwind (buf)
> Lisp_Object buf;
> {
> Lisp_Object tembuf;
> if (XBUFFER (buf) == current_buffer)
> return Qnil;
> tembuf = Fcurrent_buffer ();
> Fset_buffer (buf);
> Fkill_buffer (tembuf);
> return Qnil;
> }
Duh! I tested saving, and checked that the file's contents was right,
but never noticed this. It turns out that this code is used by
format-annotate-function, so there's a good reason for it to be there.
We should try to find a way to get both cases working right (and even
the case where build_annotations switched buffers more than once,
ideally).
The cleanest solution is to let build_annotations_unwind run some
buffer-local hook function (e.g. write-region-post-annotate-function),
which can either run kill-buffer, and/or re-narrow the buffer, and/or
kill previous buffers. The current code already allows it via
kill-buffer-hook, but using that is ugly and will lead to
other surprises.
Stefan
next prev parent reply other threads:[~2009-01-21 2:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 3:43 Please try Pmail Richard M Stallman
2009-01-18 14:47 ` Chong Yidong
2009-01-18 15:06 ` Alfred M. Szmidt
2009-01-18 20:40 ` Stefan Monnier
2009-01-19 1:41 ` Chong Yidong
2009-01-19 2:57 ` Chong Yidong
2009-01-20 4:57 ` Stefan Monnier
2009-01-20 14:20 ` Chong Yidong
2009-01-21 2:37 ` Stefan Monnier [this message]
2009-01-21 4:11 ` Chong Yidong
2009-01-21 4:18 ` Stefan Monnier
2009-01-21 15:06 ` Chong Yidong
2009-01-21 20:38 ` Stefan Monnier
2009-01-21 21:21 ` Chong Yidong
2009-01-22 4:12 ` Stefan Monnier
2009-01-22 4:55 ` Chong Yidong
2009-01-23 1:52 ` Richard M Stallman
2009-01-23 2:35 ` Chong Yidong
2009-01-21 20:32 ` Richard M Stallman
2009-01-21 21:07 ` Chong Yidong
2009-01-20 23:00 ` Richard M Stallman
2009-01-21 5:56 ` Eli Zaretskii
2009-01-20 1:00 ` Richard M Stallman
2009-01-19 4:31 ` Richard M Stallman
2009-01-19 14:39 ` Chong Yidong
2009-01-19 1:59 ` Glenn Morris
2009-01-20 0:59 ` Richard M Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvds9pfi5.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).