From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley Date: Sun, 04 Apr 2010 14:20:09 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270405238 12667 80.91.229.12 (4 Apr 2010 18:20:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Apr 2010 18:20:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: jwiegley@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 04 20:20:33 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NyUQz-0008R1-6Z for ged-emacs-devel@m.gmane.org; Sun, 04 Apr 2010 20:20:33 +0200 Original-Received: from localhost ([127.0.0.1]:33501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyUQy-0003Tc-3i for ged-emacs-devel@m.gmane.org; Sun, 04 Apr 2010 14:20:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyUQg-0003OI-3E for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:20:14 -0400 Original-Received: from [140.186.70.92] (port=37787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyUQe-0003O1-H3 for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:20:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyUQd-0004Jj-7I for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:20:12 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46864 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyUQd-0004Jd-0T for emacs-devel@gnu.org; Sun, 04 Apr 2010 14:20:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjEQAGp1uEtFpZE8/2dsb2JhbAABj1WLeHKxUYUHBIsq X-IronPort-AV: E=Sophos;i="4.51,362,1267419600"; d="scan'208";a="60190148" Original-Received: from 69-165-145-60.dsl.teksavvy.com (HELO pastel.home) ([69.165.145.60]) by ironport2-out.pppoe.ca with ESMTP; 04 Apr 2010 14:20:09 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2DBCA85F0; Sun, 4 Apr 2010 14:20:09 -0400 (EDT) In-Reply-To: (jwiegley@gmail.com's message of "Sun, 04 Apr 2010 02:55:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123172 Archived-At: Hi John, Always happy to see your contributions. Just a few points about this last one to ido.el, which might be good for other people to hear as well: - Please start your commit messages with one line that summarizes the change (so that "bzr log --short" gives useful info). - Don't expect the commit message (and/or the ChangeLog) to be read by end-users, so to advertise new end-user features, put them in etc/NEWS instead. - Before putting extra text in the change message, think whether it would be appropriate as a comment in the code instead. Between the two, we usually prefer comments. One more thing, while I'm here: IIUC this new feature doesn't work well when you have multiple files with the same name in different directories, right? I mean, it would be good to extend this feature to work well together with uniquify.el. Stefan