From: Stefan Monnier <monnier@iro.umontreal.ca>
To: jwiegley@gmail.com
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com>
Date: Sun, 04 Apr 2010 14:20:09 -0400 [thread overview]
Message-ID: <jwvvdc7jdf4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1NyK5I-00040x-CT@internal.in.savannah.gnu.org> (jwiegley@gmail.com's message of "Sun, 04 Apr 2010 02:55:19 -0400")
Hi John,
Always happy to see your contributions.
Just a few points about this last one to ido.el, which might be good for
other people to hear as well:
- Please start your commit messages with one line that summarizes the
change (so that "bzr log --short" gives useful info).
- Don't expect the commit message (and/or the ChangeLog) to be read by
end-users, so to advertise new end-user features, put them in
etc/NEWS instead.
- Before putting extra text in the change message, think whether it
would be appropriate as a comment in the code instead. Between the
two, we usually prefer comments.
One more thing, while I'm here: IIUC this new feature doesn't work well
when you have multiple files with the same name in different
directories, right? I mean, it would be good to extend this feature to
work well together with uniquify.el.
Stefan
next parent reply other threads:[~2010-04-04 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NyK5I-00040x-CT@internal.in.savannah.gnu.org>
2010-04-04 18:20 ` Stefan Monnier [this message]
2010-04-04 18:27 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99824: 2010-04-04 John Wiegley <jwiegley@gmail.com> John Wiegley
2010-04-14 11:50 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvdc7jdf4.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).