unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: Any objection to adding completing-read-function?
Date: Wed, 29 Dec 2010 10:39:32 -0500	[thread overview]
Message-ID: <jwvvd2ciock.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1ei919eop.fsf@cam.ac.uk> (Leo's message of "Wed, 29 Dec 2010 08:16:38 +0000")

> I thought C-c C-w in diff ignore all spaces but it turned out only for a
> hunk.

The issue is not so much whitespace, but the fact that you moved code
around, so diff can either show that code removed+added or show
(alternatively) show the intervening code as removed+added, depending on
which of the two is smaller.

> +  (funcall read-file-name-function
> +           prompt dir default-filename mustmatch initial predicate))

Maybe (or read-file-name-function #'read-file-name-default) is in order
here for backward compatibility, in case external code used
a let-binding to nil.


        Stefan



  reply	other threads:[~2010-12-29 15:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-28  8:03 Any objection to adding completing-read-function? Leo
2010-12-28 14:34 ` Stefan Monnier
2010-12-28 16:17   ` Drew Adams
2010-12-28 19:39     ` Stefan Monnier
2010-12-28 19:45       ` Drew Adams
2010-12-28 22:03         ` Stefan Monnier
2010-12-28 23:27           ` Leo
2010-12-29  2:51             ` Stefan Monnier
2010-12-29  8:16               ` Leo
2010-12-29 15:39                 ` Stefan Monnier [this message]
2010-12-29 16:12                   ` Leo
2011-03-20 13:07                   ` Leo
2011-03-21 14:22                     ` Stefan Monnier
2011-03-21 15:01                       ` Leo
2010-12-28 19:02   ` Leo
2010-12-28 19:45     ` Stefan Monnier
2011-05-31 15:27       ` Drew Adams
2011-05-31 15:51         ` Stefan Monnier
2011-06-01 19:03           ` Leo
2011-06-09 11:53             ` Leo
2011-06-09 15:16               ` Stefan Monnier
2011-06-21  9:11                 ` Leo
2011-06-22  1:50             ` Stefan Monnier
2011-06-22  4:15               ` Leo
2011-06-22 21:19                 ` Stefan Monnier
2011-06-23  3:42                   ` Leo
2010-12-28 16:17 ` Drew Adams
2010-12-28 19:07   ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvd2ciock.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).