From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: Recursive compilation?
Date: Mon, 06 Jun 2011 17:05:24 -0300 [thread overview]
Message-ID: <jwvvcwi4tot.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83vcwld1fh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jun 2011 19:08:34 +0300")
>> > There's a controversy about that, because there are legitimate and
>> > important use cases where Stefan's simpler solution causes trouble.
>> I think I missed that discussion. Do you have a recap, by any chance?
> The one use case I remember is when you are developing a Lisp package
> and it is not yet ready for prime time (e.g., loading it would break Emacs).
If we only change the "newest" behavior for byte-compilation, it means
the above will only apply when byte-compiling a file which requests your
temporarily-broken package. There are plenty of other ways to break
Emacs with local changes (e.g. changes that aren't ready for prime-time
applied to the Makefiles, or to C files, or ...), and there are plenty
of ways to handle this problem (e.g. "bzr shelve; make; bzr unshelve"),
so I'm really not convinced it's worth the hassle any more.
>> In any case, I think it would make sense to make this an option.
>> For instance, a new variable `byte-compile-load-newest-file'
>> defaulting to nil.
> If foo.el requires 'bar, and bar.elc is outdated, won't loading bar.el
> make the result of compiling foo.el less optimized?
No. AFAIK the only difference is for inlined functions which will be
inlined in a different way, thus resulting in different results.
I don't know of anyone who bothered to check which result is better, but
my guess is that it's a wash.
>> The obvious use case would be for the Emacs makefiles to set that
>> to t before compiling the .el files, which I'm sure would save us all a
>> bit of time over the coming years.
> Even in the Makefile's, I'm not sure it should be an obvious default:
> there could be important use cases when you'd want the warning/error
> even when building Emacs, e.g. when making a release or pretest
> tarball.
Glenn already pointed out that it's not an issue.
Any other objection?
Stefan
next prev parent reply other threads:[~2011-06-06 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 20:44 Recursive compilation? Lars Magne Ingebrigtsen
2011-05-31 21:52 ` Stefan Monnier
2011-05-31 22:17 ` Lars Magne Ingebrigtsen
2011-06-01 1:38 ` Stefan Monnier
2011-06-01 11:48 ` Lars Magne Ingebrigtsen
2011-06-01 20:14 ` Dimitri Fontaine
2011-06-03 21:55 ` Lars Magne Ingebrigtsen
2011-06-04 6:29 ` Eli Zaretskii
2011-06-04 15:54 ` Lars Magne Ingebrigtsen
2011-06-04 16:08 ` Eli Zaretskii
2011-06-04 17:50 ` Glenn Morris
2011-06-06 20:05 ` Stefan Monnier [this message]
2011-06-09 17:51 ` Lars Magne Ingebrigtsen
2011-06-04 17:48 ` Glenn Morris
2011-06-06 20:46 ` Dimitri Fontaine
2011-06-07 0:23 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvcwi4tot.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).