From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Huge file adventure (+patch)
Date: Mon, 07 Oct 2013 15:03:04 -0400 [thread overview]
Message-ID: <jwvvc187vq9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5252DB40.2060702@yandex.ru> (Dmitry Antipov's message of "Mon, 07 Oct 2013 20:03:12 +0400")
>> You can remove the { between "else" and "if" (with the side-benefit that
>> the unchanged code will stay at the same indentation level).
> Argh, OK.
>> Where/how do you make sure we loop back here for the rest
>> (when end-start > E_WRITE_MAX) ?
> Did you mean 'end - start < E_WRITE_MAX'?
No.
> Or am I creating an endless loop in e_write (BTW, I don't see how)?
Oh, sorry, I now see that the "start += coding->consumed_char;" makes
sure that if we don't encode the whole text at once, the loop will come
back to let us finish.
Please install.
Stefan
next prev parent reply other threads:[~2013-10-07 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 9:47 Huge file adventure (+patch) Dmitry Antipov
2013-10-07 15:15 ` Stefan Monnier
2013-10-07 16:03 ` Dmitry Antipov
2013-10-07 19:03 ` Stefan Monnier [this message]
2013-10-07 16:07 ` Eli Zaretskii
2013-10-07 17:07 ` Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvc187vq9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).