From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: esr@thyrsus.com, Eli Zaretskii <eliz@gnu.org>,
Paul Eggert <eggert@cs.ucla.edu>,
emacs-devel@gnu.org
Subject: Re: The fixes-bug field
Date: Fri, 17 Jan 2014 11:12:25 -0500 [thread overview]
Message-ID: <jwvvbxiiobc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mwiuzjm0.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Fri, 17 Jan 2014 16:57:43 +0100")
> I'd suggest extending this to (fixes bug#16372). That way you can refer
> to bugs without saying that you've fixed them. (I.e., the syntax is
> (<command> bug#number [optional stuff]).)
When we started using such bug#NNN in the ChangeLog (and commit logs)
I indeed wanted to use to mean "fixes bug NNN", even hoping that we
could write some commit hook that would automatically close the bug.
But in practice, I'm often not actually sure that the patch will fix the
bug when I commit it (e.g. because the recipe given in the bug-report
is clearly a subcase of the OP's real life problem, so I can't be sure
the real life problem will be fixed as well).
IOW, in many/most situations I only find out after committing that the
patch really fixes the bug. So it would work if the "fixes bug#NNN" can
be added via something like "git notes", but it won't work well in the
commit message itself.
Stefan
next prev parent reply other threads:[~2014-01-17 16:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 14:13 The fixes-bug field Eric S. Raymond
2014-01-16 16:13 ` Stefan Monnier
2014-01-16 16:30 ` Eric S. Raymond
2014-01-16 16:55 ` Eli Zaretskii
2014-01-16 17:54 ` Glenn Morris
2014-01-16 18:09 ` Eric S. Raymond
2014-01-16 18:38 ` Darren Hoo
2014-01-16 19:32 ` Stefan Monnier
2014-01-16 20:06 ` Glenn Morris
2014-01-16 21:30 ` Eli Zaretskii
2014-01-16 21:24 ` Eli Zaretskii
2014-01-16 18:55 ` Paul Eggert
2014-01-16 19:13 ` Glenn Morris
2014-01-16 20:25 ` Paul Eggert
2014-01-16 18:08 ` Eric S. Raymond
2014-01-16 18:36 ` Eli Zaretskii
2014-01-16 20:04 ` Eric S. Raymond
2014-01-16 21:29 ` Eli Zaretskii
2014-01-16 21:47 ` Eric S. Raymond
2014-01-17 7:32 ` Eli Zaretskii
2014-01-17 7:58 ` Paul Eggert
2014-01-17 8:04 ` Jarek Czekalski
2014-01-17 9:21 ` Yuri Khan
2014-01-17 14:31 ` Stefan Monnier
2014-01-17 15:57 ` Lars Ingebrigtsen
2014-01-17 16:12 ` Stefan Monnier [this message]
2014-01-17 17:20 ` Lars Ingebrigtsen
2014-01-18 9:19 ` Jarek Czekalski
2014-01-18 16:02 ` Lars Ingebrigtsen
2014-01-17 13:16 ` Eric S. Raymond
2014-01-17 13:55 ` Eli Zaretskii
2014-01-17 14:26 ` Stefan Monnier
2014-01-16 17:00 ` Glenn Morris
2014-01-16 17:22 ` Achim Gratz
2014-01-16 17:57 ` Glenn Morris
-- strict thread matches above, loose matches on Subject: below --
2014-01-16 14:15 Eric S. Raymond
2014-01-16 17:11 ` Eli Zaretskii
2014-01-17 20:29 ` Eric S. Raymond
2014-01-18 7:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbxiiobc.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).