From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Doc View Page Problems Date: Tue, 15 Apr 2014 12:51:34 -0400 Message-ID: References: <87mwfmwwsi.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1397580762 17211 80.91.229.3 (15 Apr 2014 16:52:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Apr 2014 16:52:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ian D Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 15 18:52:34 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wa6az-0000Xt-Hn for ged-emacs-devel@m.gmane.org; Tue, 15 Apr 2014 18:52:29 +0200 Original-Received: from localhost ([::1]:50642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa6az-0008Ca-8d for ged-emacs-devel@m.gmane.org; Tue, 15 Apr 2014 12:52:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa6ao-00089H-GB for emacs-devel@gnu.org; Tue, 15 Apr 2014 12:52:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wa6ag-0006n7-9I for emacs-devel@gnu.org; Tue, 15 Apr 2014 12:52:18 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:38772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wa6aX-0006jZ-Ch; Tue, 15 Apr 2014 12:52:01 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 5044984DDE; Tue, 15 Apr 2014 12:52:00 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 07A371E5B74; Tue, 15 Apr 2014 12:51:35 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id C2C1FB4180; Tue, 15 Apr 2014 12:51:34 -0400 (EDT) In-Reply-To: <87mwfmwwsi.fsf@gnu.org> (Ian D.'s message of "Tue, 15 Apr 2014 09:24:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171439 Archived-At: > patch that will solve this problem. What my fix does is updates > the default entry in `image-mode-winprops-alist' (the one with > key `t') to keep track of the current page. Then when there are > no more windows to use, it uses the last known page. Good idea. > P.S. I apologize if the bug mailing list would have been the > appropriate mailing list to which to send this. It would have worked as well, maybe even better. > diff --git a/lisp/doc-view.el b/lisp/doc-view.el > index 09d5925..0e8f511 100644 > --- a/lisp/doc-view.el > +++ b/lisp/doc-view.el > @@ -336,7 +336,7 @@ of the page moves to the previous page." > ;; Don't do it if there's a conversion is running, since in that case, it > ;; will be done later. > (with-selected-window (car winprops) > - (doc-view-goto-page 1))))) > + (doc-view-goto-page (image-mode-window-get 'page t)))))) Could you provide a ChangeLog entry for that change? Are we sure (image-mode-window-get 'page t) can't return nil? > (setf (doc-view-current-page) page > + (image-mode-window-get 'page t) page ;; Update the default page. Wouldn't it be better to do that directly inside image-mode-window-put? Stefan