From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ian D <dunni@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Doc View Page Problems
Date: Tue, 15 Apr 2014 12:51:34 -0400 [thread overview]
Message-ID: <jwvvbuamtbh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mwfmwwsi.fsf@gnu.org> (Ian D.'s message of "Tue, 15 Apr 2014 09:24:13 -0400")
> patch that will solve this problem. What my fix does is updates
> the default entry in `image-mode-winprops-alist' (the one with
> key `t') to keep track of the current page. Then when there are
> no more windows to use, it uses the last known page.
Good idea.
> P.S. I apologize if the bug mailing list would have been the
> appropriate mailing list to which to send this.
It would have worked as well, maybe even better.
> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
> index 09d5925..0e8f511 100644
> --- a/lisp/doc-view.el
> +++ b/lisp/doc-view.el
> @@ -336,7 +336,7 @@ of the page moves to the previous page."
> ;; Don't do it if there's a conversion is running, since in that case, it
> ;; will be done later.
> (with-selected-window (car winprops)
> - (doc-view-goto-page 1)))))
> + (doc-view-goto-page (image-mode-window-get 'page t))))))
Could you provide a ChangeLog entry for that change? Are we sure
(image-mode-window-get 'page t) can't return nil?
> (setf (doc-view-current-page) page
> + (image-mode-window-get 'page t) page ;; Update the default page.
Wouldn't it be better to do that directly inside image-mode-window-put?
Stefan
next prev parent reply other threads:[~2014-04-15 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 13:24 Doc View Page Problems Ian D
2014-04-15 16:51 ` Stefan Monnier [this message]
2014-04-16 13:06 ` Ian D
2014-04-16 14:18 ` Stefan Monnier
2014-04-16 16:01 ` Ian D
2014-04-16 18:09 ` Stefan Monnier
2014-04-16 19:27 ` Ian D
2014-04-17 3:58 ` Stefan Monnier
2014-04-18 20:23 ` Ian D
2014-04-20 2:47 ` Stefan Monnier
2014-04-20 3:10 ` Ian D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvbuamtbh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dunni@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).