unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring C integers to Lisp_Objects.
Date: Thu, 03 Jul 2014 09:57:00 -0400	[thread overview]
Message-ID: <jwvvbreblbi.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <53B4D81E.6010904@yandex.ru>

>> But the problem is that the code is vulnerable to these kinds
>> of changes.  Why do we even need to treat such a Lisp_Sub_Char_Table as
>> a Lisp_Vector at all?  I don't see any real need for it.
> This is somewhat similar to r110830 when we shrink struct vectorlike_header.

I'm not arguing against your optimization.  While I don't think it's
important, I'm perfectly happy if you work on such things.

But I don't see why that necessarily implies casting
Lisp_Sub_Char_Table to a Lisp_Vector (I ask this question without
having spent much time looking for the answer in the source, maybe the
answer is obvious, but I think if you can tell me why it's a better use
of my time than trying to figure it out myself).


        Stefan



  parent reply	other threads:[~2014-07-03 13:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1X2BBz-0000lE-Hh@vcs.savannah.gnu.org>
2014-07-02 14:30 ` [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring C integers to Lisp_Objects Stefan Monnier
2014-07-02 15:13   ` Dmitry Antipov
2014-07-02 15:42     ` Stefan Monnier
2014-07-02 15:54       ` Dmitry Antipov
2014-07-02 18:27         ` Stefan Monnier
2014-07-03  4:12           ` Dmitry Antipov
2014-07-03  5:01             ` Stephen J. Turnbull
2014-07-03 14:55               ` Eli Zaretskii
2014-07-03 16:12                 ` Dmitry Antipov
2014-07-03 16:37                   ` Nano-improvements " Eli Zaretskii
2014-07-03 13:57             ` Stefan Monnier [this message]
2014-07-03 15:36               ` [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring " Dmitry Antipov
2014-07-03 16:49                 ` Stefan Monnier
2014-07-03 17:01                   ` Dmitry Antipov
2014-07-03 19:52                     ` Stefan Monnier
2014-07-03 14:53             ` Nano-improvements (was: [Emacs-diffs] trunk r117464: Shrink Lisp_Sub_Char_Table by preferring C integers to Lisp_Objects.) Eli Zaretskii
2014-07-03 15:58               ` Nano-improvements Dmitry Antipov
2014-07-03 16:10                 ` Nano-improvements Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvvbreblbi.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).