From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: why do some programming modes have customize hooks and others do not? Date: Sat, 18 Oct 2014 17:46:14 -0400 Message-ID: References: <87bnp9eir3.fsf@ferrier.me.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1413668812 22041 80.91.229.3 (18 Oct 2014 21:46:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Oct 2014 21:46:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nic Ferrier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 18 23:46:45 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xfbpl-0004Cc-G3 for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2014 23:46:45 +0200 Original-Received: from localhost ([::1]:37829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xfbpl-0000Pz-2x for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2014 17:46:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfbpR-0000Nr-7C for emacs-devel@gnu.org; Sat, 18 Oct 2014 17:46:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XfbpH-0000Rr-8m for emacs-devel@gnu.org; Sat, 18 Oct 2014 17:46:25 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:45581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfbpH-0000Rg-4f for emacs-devel@gnu.org; Sat, 18 Oct 2014 17:46:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVNFxKjo/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="94541490" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Oct 2014 17:46:14 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 5E6DB6542; Sat, 18 Oct 2014 17:46:14 -0400 (EDT) In-Reply-To: <87bnp9eir3.fsf@ferrier.me.uk> (Nic Ferrier's message of "Sat, 18 Oct 2014 12:10:08 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:175544 Archived-At: > Emacs-Lisp mode has a customizable hook variable but erlang-mode does > not. define-derived-mode currently defines the hook with `defvar', so you'll only get a customizable hook if the mode author explicitly added a defcustom for it. Maybe define-derived-mode should define the hook with defcustom. I guess we'd need some motivation (other than "consistency") for that, such as what would be the benefit to define the hook as a defcustom if all the defcustom says is ":type hook". Stefan