* Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
[not found] ` <E1YkrId-00075y-5s@vcs.savannah.gnu.org>
@ 2015-04-22 14:34 ` Stefan Monnier
2015-04-25 20:53 ` Alan Mackenzie
2015-04-23 18:01 ` Glenn Morris
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-04-22 14:34 UTC (permalink / raw)
To: emacs-devel; +Cc: Alan Mackenzie
> + (with-silent-modifications
> + (let ((inhibit-read-only t))
> + (dolist (handler yank-handled-properties)
> + (let ((prop (car handler))
> + (fun (cdr handler))
> + (run-start start))
> + (while (< run-start end)
> + (let ((value (get-text-property run-start prop))
> + (run-end (next-single-property-change
> + run-start prop nil end)))
> + (funcall fun value run-start run-end)
Running the hook functions within with-silent-modifications sounds
dangerous since they may make modifications which shouldn't be ignored
(only the hooks can know).
> + (if (eq yank-excluded-properties t)
> + (set-text-properties start end nil)
> + (remove-list-of-text-properties start end yank-excluded-properties)))))
This is the part that needs to be wrapped.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
2015-04-22 14:34 ` [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list Stefan Monnier
@ 2015-04-25 20:53 ` Alan Mackenzie
2015-04-26 4:11 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Alan Mackenzie @ 2015-04-25 20:53 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hello, Stefan.
On Wed, Apr 22, 2015 at 10:34:20AM -0400, Stefan Monnier wrote:
> > + (with-silent-modifications
> > + (let ((inhibit-read-only t))
> > + (dolist (handler yank-handled-properties)
> > + (let ((prop (car handler))
> > + (fun (cdr handler))
> > + (run-start start))
> > + (while (< run-start end)
> > + (let ((value (get-text-property run-start prop))
> > + (run-end (next-single-property-change
> > + run-start prop nil end)))
> > + (funcall fun value run-start run-end)
> Running the hook functions within with-silent-modifications sounds
> dangerous since they may make modifications which shouldn't be ignored
> (only the hooks can know).
> > + (if (eq yank-excluded-properties t)
> > + (set-text-properties start end nil)
> > + (remove-list-of-text-properties start end yank-excluded-properties)))))
> This is the part that needs to be wrapped.
Sorry about that. I've corrected it now.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
[not found] ` <E1YkrId-00075y-5s@vcs.savannah.gnu.org>
2015-04-22 14:34 ` [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list Stefan Monnier
@ 2015-04-23 18:01 ` Glenn Morris
2015-04-25 21:06 ` Alan Mackenzie
1 sibling, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2015-04-23 18:01 UTC (permalink / raw)
To: emacs-devel; +Cc: Alan Mackenzie
Alan Mackenzie wrote:
> Commit: Alan Mackenzie <acm@muc.de>
>
> On C-y, stop some text property entries being written into buffer-undo-list
>
> lisp/subr.el (remove-yank-excluded-properties): enclose the code in
> `with-silent-modifications'.
Please include the "* " before the file name in your logs.
Eg use C-c C-a as described in CONTRIBUTE.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list
2015-04-23 18:01 ` Glenn Morris
@ 2015-04-25 21:06 ` Alan Mackenzie
0 siblings, 0 replies; 5+ messages in thread
From: Alan Mackenzie @ 2015-04-25 21:06 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
Hello, Glenn.
On Thu, Apr 23, 2015 at 02:01:02PM -0400, Glenn Morris wrote:
> Alan Mackenzie wrote:
> > Commit: Alan Mackenzie <acm@muc.de>
> > On C-y, stop some text property entries being written into buffer-undo-list
> > lisp/subr.el (remove-yank-excluded-properties): enclose the code in
> > `with-silent-modifications'.
> Please include the "* " before the file name in your logs.
> Eg use C-c C-a as described in CONTRIBUTE.
OK.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-04-26 4:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150422095031.27238.96994@vcs.savannah.gnu.org>
[not found] ` <E1YkrId-00075y-5s@vcs.savannah.gnu.org>
2015-04-22 14:34 ` [Emacs-diffs] master c5e89be: On C-y, stop some text property entries being written into buffer-undo-list Stefan Monnier
2015-04-25 20:53 ` Alan Mackenzie
2015-04-26 4:11 ` Stefan Monnier
2015-04-23 18:01 ` Glenn Morris
2015-04-25 21:06 ` Alan Mackenzie
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).