From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 1f680db: Fix compilation next-error in buffers with selective-display Date: Sun, 03 Jan 2016 11:02:17 -0500 Message-ID: References: <20160103152320.26638.30195@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451836965 1651 80.91.229.3 (3 Jan 2016 16:02:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jan 2016 16:02:45 +0000 (UTC) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 03 17:02:27 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aFl6x-0004vN-OT for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 17:02:27 +0100 Original-Received: from localhost ([::1]:42089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFl6x-00079t-2S for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 11:02:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFl6u-00079i-4J for emacs-devel@gnu.org; Sun, 03 Jan 2016 11:02:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aFl6q-0001iR-Us for emacs-devel@gnu.org; Sun, 03 Jan 2016 11:02:24 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:51685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFl6q-0001i9-Q3; Sun, 03 Jan 2016 11:02:20 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id u03G2Hhr009438; Sun, 3 Jan 2016 11:02:18 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 1B7BAAE310; Sun, 3 Jan 2016 11:02:17 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Sun, 03 Jan 2016 15:23:20 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5539=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5539> : inlines <4174> : streams <1564819> : uri <2113493> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197458 Archived-At: > +(defun compilation-beginning-of-line (&optional n) > + "Like `beginning-of-line', but accounts for lines hidden by `selective-display'." > + (if (or (not (eq selective-display t)) > + (null n) > + (= n 1)) > + (beginning-of-line n) > + (re-search-forward "[\n\r]" nil 'end (1- n)) > + (if (< n 0) > + (beginning-of-line)))) All this extra cruft to support an obsolete feature we should eliminate is the reason why I didn't fix it earlier. There are reams of other places where selective-display can cause errors and where similar "simple" fixes could be added. The problem is/was not in compile.el but in selective-display (which should just die its deserved death). Stefan