From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] emacs-25 1f680db: Fix compilation next-error in buffers with selective-display
Date: Sun, 03 Jan 2016 11:02:17 -0500 [thread overview]
Message-ID: <jwvvb7azm9a.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1aFkV6-0006wH-Be@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 03 Jan 2016 15:23:20 +0000")
> +(defun compilation-beginning-of-line (&optional n)
> + "Like `beginning-of-line', but accounts for lines hidden by `selective-display'."
> + (if (or (not (eq selective-display t))
> + (null n)
> + (= n 1))
> + (beginning-of-line n)
> + (re-search-forward "[\n\r]" nil 'end (1- n))
> + (if (< n 0)
> + (beginning-of-line))))
All this extra cruft to support an obsolete feature we should eliminate
is the reason why I didn't fix it earlier.
There are reams of other places where selective-display can cause errors
and where similar "simple" fixes could be added.
The problem is/was not in compile.el but in selective-display (which
should just die its deserved death).
Stefan
next parent reply other threads:[~2016-01-03 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160103152320.26638.30195@vcs.savannah.gnu.org>
[not found] ` <E1aFkV6-0006wH-Be@vcs.savannah.gnu.org>
2016-01-03 16:02 ` Stefan Monnier [this message]
2016-01-03 16:50 ` [Emacs-diffs] emacs-25 1f680db: Fix compilation next-error in buffers with selective-display Eli Zaretskii
2016-01-03 19:56 ` John Wiegley
2016-01-04 1:00 ` Stefan Monnier
2016-01-04 15:43 ` Eli Zaretskii
2016-01-05 4:18 ` Stefan Monnier
2016-01-05 16:53 ` Eli Zaretskii
2016-01-04 3:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvvb7azm9a.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).