From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Abbrev suggestions - feedback appreciated Date: Sat, 16 Sep 2017 09:22:20 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505568190 29310 195.159.176.226 (16 Sep 2017 13:23:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2017 13:23:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 16 15:23:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtD3p-0007Rc-Cy for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 15:23:05 +0200 Original-Received: from localhost ([::1]:57322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtD3u-0002xE-V8 for ged-emacs-devel@m.gmane.org; Sat, 16 Sep 2017 09:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtD3J-0002ww-Dx for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:22:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtD3G-0005ip-A8 for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:22:33 -0400 Original-Received: from [195.159.176.226] (port=40853 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtD3G-0005hj-2E for emacs-devel@gnu.org; Sat, 16 Sep 2017 09:22:30 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dtD34-0006IK-KP for emacs-devel@gnu.org; Sat, 16 Sep 2017 15:22:18 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:eNGStZSD1pKil5IeLTFJGh182hI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218358 Archived-At: > (defun absug-maybe-suggest () > "Suggest an abbrev to the user based on the word before point." > (let* ((word (absug-word-before-point)) > (expansions (absug-get-active-abbrev-expansions)) > (abbrev (assoc word expansions))) > (if abbrev > (message "Abbrev suggestion: The word `%s' has the abbrev > `%s' defined" (car abbrev) (cdr abbrev))))) I like the feature. Here are some comments: - The expansion is not necessarily a "word". - The `expansions` list is built only to then pass it to `assoc`. You could avoid constructing the list by passing `word` to absug-get-active-abbrev-expansions and have it check equality as it goes. Stefan