From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 671dc5a: Fix calls to buffer modification hooks from replace-buffer-contents Date: Sun, 22 Jul 2018 01:18:48 -0400 Message-ID: References: <20180721180616.6608.26581@vcs0.savannah.gnu.org> <20180721180618.5CEA9208D4@vcs0.savannah.gnu.org> <83bmb0xxcy.fsf@gnu.org> <838t64xwqe.fsf@gnu.org> <836018xvux.fsf@gnu.org> <834lgsxa69.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532236617 28403 195.159.176.226 (22 Jul 2018 05:16:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 05:16:57 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 22 07:16:52 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh6jk-0007Ik-Qs for ged-emacs-devel@m.gmane.org; Sun, 22 Jul 2018 07:16:52 +0200 Original-Received: from localhost ([::1]:54858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fh6lr-0003cO-FI for ged-emacs-devel@m.gmane.org; Sun, 22 Jul 2018 01:19:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fh6lh-0003c8-Um for emacs-devel@gnu.org; Sun, 22 Jul 2018 01:18:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fh6le-0007hO-Qb for emacs-devel@gnu.org; Sun, 22 Jul 2018 01:18:53 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fh6le-0007hJ-Li; Sun, 22 Jul 2018 01:18:50 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w6M5Inct004188; Sun, 22 Jul 2018 01:18:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 0986465491; Sun, 22 Jul 2018 01:18:49 -0400 (EDT) In-Reply-To: <834lgsxa69.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 05:43:10 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6334=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6334> : inlines <6769> : streams <1793254> : uri <2677243> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227651 Archived-At: >> It's about the text in the two comments you introduced: they say (or at >> least can be interpreted to say) that the code may run only one of the >> two hooks in some cases. If that text is a correct description of the >> code, it means we have a bug in the code, and if not it means those >> comments should be improved. > Well, I hope you are happy now, because those comments are gone. I wasn't unhappy, I was just wondering, Stefan