From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7cfe2dc: In edebug in GUIs, move focus to the selected frame. Date: Fri, 19 Oct 2018 17:12:38 -0400 Message-ID: References: <20181019175416.10874.88992@vcs0.savannah.gnu.org> <20181019175418.27D6920407@vcs0.savannah.gnu.org> <20181019184916.GA6639@ACM> <20181019192132.GB6639@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539983484 6238 195.159.176.226 (19 Oct 2018 21:11:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Oct 2018 21:11:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 19 23:11:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDc3E-0001Xn-0N for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 23:11:20 +0200 Original-Received: from localhost ([::1]:52744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDc5J-0003Vn-Uu for ged-emacs-devel@m.gmane.org; Fri, 19 Oct 2018 17:13:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDc4Z-0003Vg-7U for emacs-devel@gnu.org; Fri, 19 Oct 2018 17:12:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDc4W-0004yv-2H for emacs-devel@gnu.org; Fri, 19 Oct 2018 17:12:43 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:34069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDc4V-0004xk-SC for emacs-devel@gnu.org; Fri, 19 Oct 2018 17:12:39 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w9JLCcnd021222; Fri, 19 Oct 2018 17:12:39 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 8537BAE152; Fri, 19 Oct 2018 17:12:38 -0400 (EDT) In-Reply-To: <20181019192132.GB6639@ACM> (Alan Mackenzie's message of "Fri, 19 Oct 2018 19:21:32 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6399=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6399> : inlines <6936> : streams <1801794> : uri <2733947> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230512 Archived-At: >> If the intention is only to display the code shouldn't use pop-to-buffer >> but display-buffer. > The doc string of display-buffer is a bit of a heavy read at this time > of night. ;-) pop-to-buffer is no simpler: it's basically the same as (select-window (display-buffer BUF)). BTW, pop-to-buffer already calls `select-frame-set-input-focus`. And I see that edebug-pop-to-buffer doesn't call pop-to-buffer, and that it comes with: ;; FIXME: We should probably just be using `pop-to-buffer'. So maybe the better path is indeed to scratch edebug-pop-to-buffer and use pop-to-buffer instead (or more likely, to change edebug-pop-to-buffer so that it uses pop-to-buffer internally). > Most Emacs users restrict themselves to just one frame? Ouch! I > couldn't work like that! At least, that's the conclusion I draw from years of fighting code using save-window-excursion and such. Stefan