From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 134ba45: Allow two mouse functions to work with Rectangle Mark mode Date: Fri, 26 Oct 2018 13:25:25 -0400 Message-ID: References: <20181017063829.3775.67018@vcs0.savannah.gnu.org> <20181017063831.03DCB2044D@vcs0.savannah.gnu.org> <810f1e04-1117-476d-9a7d-d57002609bf8@default> <5BCC3743.8040103@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540574621 21914 195.159.176.226 (26 Oct 2018 17:23:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2018 17:23:41 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: martin rudalics , emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 26 19:23:36 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG5pg-0005b5-BH for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 19:23:36 +0200 Original-Received: from localhost ([::1]:33370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5rm-0000y0-U0 for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 13:25:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5rf-0000xH-VP for emacs-devel@gnu.org; Fri, 26 Oct 2018 13:25:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG5rc-0006Mw-5i for emacs-devel@gnu.org; Fri, 26 Oct 2018 13:25:39 -0400 Original-Received: from alt22.smtp-out.videotron.ca ([70.80.0.73]:40887) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gG5rb-0006Hs-Tv for emacs-devel@gnu.org; Fri, 26 Oct 2018 13:25:36 -0400 Original-Received: from fmsmemgm.homelinux.net ([23.233.195.134]) by Videotron with SMTP id G5rRgAHqEELtdG5rUgYURB; Fri, 26 Oct 2018 13:25:29 -0400 X-Authority-Analysis: v=2.3 cv=atGc9xRV c=1 sm=1 tr=0 a=xXJ578j8WyTliCxld3/pTA==:117 a=xXJ578j8WyTliCxld3/pTA==:17 a=smKx5t2vBNcA:10 a=0xYJNeH_2nx-4OiUeqwA:9 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A3E58AE31A; Fri, 26 Oct 2018 13:25:25 -0400 (EDT) In-Reply-To: (Federico Tedin's message of "Thu, 25 Oct 2018 20:24:28 -0300") X-CMAE-Envelope: MS4wfGpJyyKybujiJAIkh2pyR71mLEdh1njM9UWK3iXQgYpyYOEdzoWjq47aCqa+NuIB2+kCJ7jMJy3K2qUk//lkrhJxZ//P47YIThD0TUYoc03LptyDoHoH WgIdZ3xMYVWhTSijT+ocfuXFnVHrSV534PSClWL2CSFREbmVffvoDio1eR6Zsnk3iLhecV1d9ueqlr2aXSRTpF8vlYGY3WHTFQjsKyEDGcWlzZjbtY+j78ai 8pT+jYQFpeHVxzA7G/4PxgdJXm60cGpnmpK2JGs/VPP2bVJ5bOH/4OIDZ9Yqsa2u X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 70.80.0.73 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230718 Archived-At: > Stefan, I've prepared a patch that fixes most of the problems you > found with my commit. Thanks, installed (after changing text-property-any with text-property-not-all so we also detect non-t non-nil values as meaning "read-only"). > Although this patch tidies up mouse-drag-and-drop-region, the problem > of always treating noncontiguous regions as rectangles still remains. > I have limited experience writing Emacs Lisp so I am not sure what the > options are to solve this, but I'm interested in participating in the > process of thinking/implementing a solution. AFAICT the next step is to introduce a function `reactivate-mark`. This function will need to know what kind of mark was earlier activated, so we will need to store the "kind of mark" somewhere. I guess the easiest is to introduce a new var `reactivate-mark-function` (so reactivate-mark doesn't need to do much more than funcall it). Then we'll want to change a few places in Elisp to set/reset this var. Stefan