From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: VOTE: Changing completions-common-part face's default Date: Thu, 07 Nov 2019 10:08:52 -0500 Message-ID: References: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> <87pni7p83l.fsf@gmail.com> <87h83ipoi0.fsf@gmail.com> <93235eb5-8e04-7182-e2a4-49fbe610ee2b@yandex.ru> <28d4ae09-daca-324b-2fa6-9d7138d710fa@yandex.ru> Mime-Version: 1.0 Content-Type: text/x-markdown; charset=UTF-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157684"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 07 16:09:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSjQ6-000esA-37 for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 16:09:58 +0100 Original-Received: from localhost ([::1]:44154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSjQ4-0002nY-Li for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 10:09:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55860) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSjP9-0002Jn-Ax for emacs-devel@gnu.org; Thu, 07 Nov 2019 10:09:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSjP7-0004TM-QT for emacs-devel@gnu.org; Thu, 07 Nov 2019 10:08:58 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23039) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSjP7-0004T3-J5 for emacs-devel@gnu.org; Thu, 07 Nov 2019 10:08:57 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 93646449973; Thu, 7 Nov 2019 10:08:56 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5F146449962; Thu, 7 Nov 2019 10:08:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1573139335; bh=WDTOjerNf/bJK8ZS2BDLvd02SR4KEtabNQlNRuBYF2A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Nf0Q39LM+1QEKmHLOS5ucNF6hRsm1FkZpH0nA+eiyr4K823kztWUeR4+Idwk43EQk fBOPZQ5+iZcuk2CatczYb6Yv/iftktmDe+G3BUurbaCy141FW56NLRvdL8+zwXTE0s rn+tS7X1aAzRRLPg+BRBdPfH6Y+NYrY7Ijo3NL9TyuRFzWaPOXAp4v2ysQkHeUj2pE pQ/lLRQrkNc4o4Wt0o3kbSxoGC0fVpCnWniwVv87P7waIQsNgpiGyIYHbGJNd3zvMe M256+WyMFSRIXHMFI0ZM5t8TpEYAVMyEONfcSTCJimLDAWngYaFGceSgUTBfNXrX2w Ix8nebmS1bphQ== Original-Received: from pastel (unknown [216.154.47.134]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 130921200C7; Thu, 7 Nov 2019 10:08:55 -0500 (EST) In-Reply-To: <28d4ae09-daca-324b-2fa6-9d7138d710fa@yandex.ru> (Dmitry Gutov's message of "Thu, 7 Nov 2019 10:09:32 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241935 Archived-At: > Yes, sure. But that's an easy bar to clean because I'm fine with what we > have now (no highlighting for common-part). Great, so you represent an important part of the audience. > blue3 is *very* noticeable, That's the goal (maybe not the "very" but the "noticeable"). > which brings back the main objection to using it for prefix completion. To be honest, I'm not completely sure what is the main objection. I chose `blue3` so far because while noticeable it seems to me that it doesn't affect the overall legibility nor makes the first-diff less noticeable. So, yes, it's "useless" highlighting for basic/prefix-completion, but that's pretty much a given. "useless" is compatible with "harmless". > I recognize others feel differently, though. > So if blue4 also works for your stated goal, which is I could live with "blue4" but it's significantly less visible, so I think the only role it could play is to advertise the existence of the face, but nothing else: I expect that very few people who want to see the common-part (e.g. because they're using flex) will find it sufficient, whereas I suspect that `blue3` would be "good enough" for a non-negligible fraction of those users. It is better than what we have, IMO, so I'm willing to "retreat" to `blue4` for this "first step" if you really think `blue3` harms the basic/prefix-completion case. Stefan