unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: dancol@dancol.org
Cc: niwtrx@icloud.com, Paul Eggert <eggert@cs.ucla.edu>,
	emacs-devel@gnu.org, 38912@debbugs.gnu.org,
	Pip Cet <pipcet@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded
Date: Tue, 07 Jan 2020 09:16:31 -0500	[thread overview]
Message-ID: <jwvv9pnz76y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f8866ddf-66d2-4406-92a8-15f11554e270@email.android.com> (dancol@dancol.org's message of "Mon, 06 Jan 2020 19:34:06 -0800")

>  The worst case is window configurations, where there's a nontrivial 
>  function compare_window_configurations that Fequal delegates to.

Indeed, this is very strange.

>  Does anyone know offhand why we don't simply use eq to compare window 
>  configurations?

I'm curious about it too.  As a long-time Elisp coder, I find this
behavior very odd (I just discovered it while looking at the code)
and I think having them compared by identity would make a lot more sense.

> I think changing the equal behavior of these objects would be
> a compatibility change.

Indeed.  It's clearly out of the question for Emacs-27.  But I'd be in
favor of introducing this backward incompatibility in Emacs-28, unless
we can find a good use case where the structural-equality is needed
for them.


        Stefan




  reply	other threads:[~2020-01-07 14:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <333553AC-68DE-4F1C-9586-5A13248AD6DD@icloud.com>
     [not found] ` <83ftgvh96l.fsf@gnu.org>
     [not found]   ` <D1473DD8-48F8-4204-80B5-BE6396B8B668@icloud.com>
     [not found]     ` <83a771g2tc.fsf@gnu.org>
     [not found]       ` <CAOqdjBfjpSqhDcMiHGQfaOGZEodmjmvhQionRPO1OQ0sVsLDPg@mail.gmail.com>
     [not found]         ` <83o8vgee85.fsf@gnu.org>
     [not found]           ` <8b2e879676c6ecc1371d50e033164424.squirrel@dancol.org>
2020-01-06 17:13             ` bug#38912: 27.0.60; PDumper meets segmentation fault when evil is loaded Pip Cet
2020-01-07  2:38               ` Paul Eggert
2020-01-07  3:34                 ` dancol
2020-01-07 14:16                   ` Stefan Monnier [this message]
2020-01-07 19:32                     ` Paul Eggert
2020-01-07 15:47                 ` Eli Zaretskii
2020-01-07 17:37                   ` Stefan Monnier
2020-01-07 17:43                     ` Eli Zaretskii
2020-01-07 18:01                       ` Stefan Monnier
2020-01-07 18:11                         ` Eli Zaretskii
2020-01-07 18:47                           ` Stefan Monnier
2020-01-07 18:29                         ` martin rudalics
2020-01-07 18:43                           ` Stefan Monnier
2020-01-07 18:58                             ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvv9pnz76y.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=38912@debbugs.gnu.org \
    --cc=dancol@dancol.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=niwtrx@icloud.com \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).