From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: "Štěpán Němec" <stepnem@gmail.com>
Subject: Re: master 188bd80: gnus-shorten-url: Improve and avoid args-out-of-range error
Date: Mon, 13 Apr 2020 12:51:58 -0400 [thread overview]
Message-ID: <jwvv9m3nxfa.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20200413102417.445E520D0C@vcs0.savannah.gnu.org> ("閣?p疣 N?mec"'s message of "Mon, 13 Apr 2020 06:24:16 -0400 (EDT)")
> +;;;###autoload
> +(defun string-truncate-left (string length)
> + "Truncate STRING to LENGTH, replacing initial surplus with \"...\"."
> + (let ((strlen (length string)))
> + (if (<= strlen length)
> + string
> + (setq length (max 0 (- length 3)))
> + (concat "..." (substring string (max 0 (- strlen 1 length)))))))
This should of course rely on string-width rather than string-length,
but more importantly, it should obey `truncate-string-ellipsis` and
it should be "closer" to `truncate-string-to-width` (they should likely
be in the same file, and with similar sounding names).
Maybe it should even be merged with `truncate-string-to-width`.
Stefan
next parent reply other threads:[~2020-04-13 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200413102415.23314.52412@vcs0.savannah.gnu.org>
[not found] ` <20200413102417.445E520D0C@vcs0.savannah.gnu.org>
2020-04-13 16:51 ` Stefan Monnier [this message]
2020-04-14 9:26 ` master 188bd80: gnus-shorten-url: Improve and avoid args-out-of-range error Štěpán Němec
2020-04-14 11:55 ` Eli Zaretskii
2020-04-14 12:24 ` Štěpán Němec
2020-04-14 12:42 ` Eli Zaretskii
2020-04-14 13:48 ` Štěpán Němec
2020-04-14 17:51 ` Eli Zaretskii
2020-04-14 15:02 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv9m3nxfa.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).