From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/completions-highlight-modifications e3c5b99 3/6: Add completions-highlight-mode initial implementation. Date: Sun, 15 Nov 2020 18:32:08 -0500 Message-ID: References: <20201115023629.19537.77471@vcs0.savannah.gnu.org> <20201115023631.C78AB20A27@vcs0.savannah.gnu.org> <20201115224943.o5r7lkkblmyt2ox4@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19562"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 16 00:33:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keRWt-0004AK-EC for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Nov 2020 00:33:55 +0100 Original-Received: from localhost ([::1]:59506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keRWF-0004lz-H8 for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Nov 2020 18:33:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keRVI-0004HB-8f for emacs-devel@gnu.org; Sun, 15 Nov 2020 18:32:17 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25986) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keRVE-0008UW-HC for emacs-devel@gnu.org; Sun, 15 Nov 2020 18:32:15 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1A5E180B6D; Sun, 15 Nov 2020 18:32:11 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9D6388091C; Sun, 15 Nov 2020 18:32:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1605483129; bh=h0vW6pBP7yP+CGwHeYj0GJRhhXuXenW18QRraZUOxXI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZRv4L4aUkjAdfR/vN6d3Xseu3CwSyOyRwSme8EDBldAxw2PE1xNwXPzRTVnNGzzRA fXO5yumkwFlLGrQLHAbtmRrNCZet9ZyMhHDqM+9Xqy8N/bVMZczB97ZdHt5GOYcfLh chCYCxJ/vzMIe09ZaonlOp39g1wGVBTg/pKQ34+hK1rq8Rvg9BAElC+14Dn8Yx8OaE wFzglX6jtdfyYTgBnn2KowFYabY1+psTcnnc0NXqzJyrEbCA7mcAegZWC7ti01nsOt 5PVO0nOo1C5YuI+p9xYTFDv5XSyMyizx0NIyhu3MHLNdJ/NC8JrnF9zeUkLfvr0UTO pQuzLA1MjFV/Q== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 72E98120153; Sun, 15 Nov 2020 18:32:09 -0500 (EST) In-Reply-To: <20201115224943.o5r7lkkblmyt2ox4@Ergus> (Ergus's message of "Sun, 15 Nov 2020 23:49:43 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 17:01:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259212 Archived-At: >> Please write a description that can be understood by someone who doesn't >> know Zsh (or Helm or Ivy or ...). > Done! Much better, thanks. > Maybe it needs some comments in the manual/NEWS too? If so, where? I haven't looked at it enough to know, yet, sorry. > Please check if it needs anything else to be merged into master. I am > reusing the highlight face... but maybe the package needs its own face > for the overlay? Sorry haven't looked at the code yet. > How can I make that emacs find the file automatically? It needs to be > added in cus-.el right? What do you mean by "find the file automatically"? BTW, this new feature reminds me of completion-cycle-threshold. Stefan