From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el
Date: Wed, 24 Feb 2021 15:57:18 -0500 [thread overview]
Message-ID: <jwvv9ahjibz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210224193217.F016720B28@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2021 14:32:17 -0500 (EST)")
> + ;; This is a funcall to avoid `quail-update-leim-list-file'
> + ;; determining that this is a quail definition (it searches for
> + ;; "(quail-define-package").
> + (funcall #'quail-define-package pkgname lang title nil docstring
Would the patch below fix this problem more directly?
Stefan
diff --git a/lisp/international/quail.el b/lisp/international/quail.el
index 5cfa79203d..576189a7de 100644
--- a/lisp/international/quail.el
+++ b/lisp/international/quail.el
@@ -3081,7 +3081,7 @@ quail-update-leim-list-file
(insert-file-contents (car pkg-list))
(goto-char (point-min))
;; Don't get fooled by commented-out code.
- (while (re-search-forward "^[ \t]*(quail-define-package" nil t)
+ (while (re-search-forward "^[ \t]*(quail-define-package[ \t\n]*\"" nil t)
(goto-char (match-beginning 0))
(condition-case nil
(let ((form (read (current-buffer))))
next parent reply other threads:[~2021-02-24 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210224193216.21758.72611@vcs0.savannah.gnu.org>
[not found] ` <20210224193217.F016720B28@vcs0.savannah.gnu.org>
2021-02-24 20:57 ` Stefan Monnier [this message]
2021-02-24 21:02 ` master 8fd97b1 1/2: Fix warning generated by indian.el + quail.el Lars Ingebrigtsen
2021-02-24 21:19 ` Stefan Monnier
2021-02-24 22:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvv9ahjibz.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).