From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 12:37:59 -0400 Message-ID: References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <87k0pu887d.fsf@gnus.org> <87zgyq9bbb.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20489"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Michael Albinus , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 17:38:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPpTz-0005Dn-NW for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 17:38:47 +0100 Original-Received: from localhost ([::1]:41284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPpTy-0001Sn-Ne for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 12:38:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPpTK-000120-Fb for emacs-devel@gnu.org; Fri, 26 Mar 2021 12:38:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPpTH-0004dg-7f for emacs-devel@gnu.org; Fri, 26 Mar 2021 12:38:04 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E7EE0100241; Fri, 26 Mar 2021 12:38:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 75A2010021B; Fri, 26 Mar 2021 12:38:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616776680; bh=703pTLk6jQCkNcTOjgTspe0irUOzp3UUDIbtIeVhESQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nqBXVA+EXcXTjQ1F7keovjZhK25gbQysW54AXd2aOii51eEGOOjeARy8kjEY4o5Mj u/a5Jfx7TX0Bp+fFsLgzzVU8J13a0jRkQoZXSVWz7DftVlcytGX+hkg1Og6GF/gD7v E+izyLO/+NcVMM8kk86x8vaXOvAaADbYoozr6uuapvuApvTDwGv6nsjFZoIvvOiO67 61t/lo6cfz+5YyMycFvSIoBWE192TowhQrr+QwzFNOvS1bQBRKHKMqPYJorvjky4yi Kdl7Qyy+GRjBo+6TsVvGR9sttJqIJLLwlcqm7aEfDSYIs9hAKPSMq9YuhA3Mxw1dQ0 DIAjBcrqQrMHA== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3D3441203CE; Fri, 26 Mar 2021 12:38:00 -0400 (EDT) In-Reply-To: <87zgyq9bbb.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Mar 2021 15:36:24 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267080 Archived-At: >>> Yup; if it's hoisted out of the loop, there'd be no performance impact, >>> but it would make it less useful, though -- as with erroring out, you'd >>> get no completion. >> >> It'd make more sense to just keep the current (not-filtered) completion >> list, so you still get completion to work. > > If we stick with the original patch, then that would mean returning > non-nil rather than nil if completion-predicate fails, right? I don't think whether we include the command for which the predicate burped is important: either way is fine. OTOH, it would be preferable if a burping predicate wouldn't prevent the inclusion of other commands in the completion list. It's probably tolerable to just prevent completion altogether in case of an error, but not to prevent `M-x` altogether. Stefan