Re: [elpa] externals/pyim bf3626c 05/36: * pyim-common.el (pyim-flatten-list): Move from pyim.el

Re: [elpa] externals/pyim bf3626c 05/36: * pyim-common.el (pyim-flatten-list): Move from pyim.el

[Stefan Monnier]

> +(defun pyim-flatten-list (my-list)
> +  (cond
> +   ((null my-list) nil)
> +   ((atom my-list) (list my-list))
> +   (t (append (pyim-flatten-list (car my-list))
> +              (pyim-flatten-list (cdr my-list))))))

I believe this is called `flatten-tree` in Emacs-27.


        Stefan

Re: [elpa] externals/pyim 09fd273 07/36: Sort pyim-common.el

[Stefan Monnier]

> +(defun pyim-exwm-enable-p ()
> +  "测试当前是否是 exwm 环境。"
> +  (string-match-p " \\*temp\\*" (buffer-name)))

I think this deserves a comment explaining why this test indicates
whether we're in exwm.  After all, ` *temp*` is the name of the buffers
used by `with-temp-buffer`, so AFAIK there can be lots and lots of
circumstances where the current buffer's name is ` *temp*`, regardless
of whether we're using exwm.


        Stefan

Re: [elpa] externals/pyim 9f017ac 18/36: New file: pyim-entered.el

[Stefan Monnier]

> +  (pyim-with-entered-buffer
> +    (cond
> +     ((equal 1 (point))
> +      (buffer-string))
> +     ((eq type 'point-before)
> +      (buffer-substring-no-properties 1 (point)))

I recommend you use (point-min) rather than hardcoding 1.
It's a good practice in general, and as a bonus it leads to marginally
better bytecode.


        Stefan

Re:Re: [elpa] externals/pyim bf3626c 05/36: * pyim-common.el (pyim-flatten-list): Move from pyim.el

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

Fixed, thanks!





















At 2021-04-23 11:10:42, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
>> +(defun pyim-flatten-list (my-list)
>> +  (cond
>> +   ((null my-list) nil)
>> +   ((atom my-list) (list my-list))
>> +   (t (append (pyim-flatten-list (car my-list))
>> +              (pyim-flatten-list (cdr my-list))))))
>
>I believe this is called `flatten-tree` in Emacs-27.
>
>
>        Stefan

[-- Attachment #2: Type: text/html, Size: 808 bytes --]

Re:Re: [elpa] externals/pyim 9f017ac 18/36: New file: pyim-entered.el

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Fixed, thanks!





















At 2021-04-23 11:19:49, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
>> +  (pyim-with-entered-buffer
>> +    (cond
>> +     ((equal 1 (point))
>> +      (buffer-string))
>> +     ((eq type 'point-before)
>> +      (buffer-substring-no-properties 1 (point)))
>
>I recommend you use (point-min) rather than hardcoding 1.
>It's a good practice in general, and as a bonus it leads to marginally
>better bytecode.
>
>
>        Stefan

[-- Attachment #2: Type: text/html, Size: 872 bytes --]

Re: [elpa] externals/pyim 9f017ac 18/36: New file: pyim-entered.el

[Andreas Schwab]

On Apr 22 2021, Stefan Monnier wrote:

>> +  (pyim-with-entered-buffer
>> +    (cond
>> +     ((equal 1 (point))
>> +      (buffer-string))
>> +     ((eq type 'point-before)
>> +      (buffer-substring-no-properties 1 (point)))
>
> I recommend you use (point-min) rather than hardcoding 1.
> It's a good practice in general, and as a bonus it leads to marginally
> better bytecode.

Also, (equal 1 (point)) should be written as (bobp).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."