From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Patch: debug-instrumented predicate Date: Mon, 04 Oct 2021 12:24:13 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 18:26:44 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXQna-0005V2-0w for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 18:26:42 +0200 Original-Received: from localhost ([::1]:57996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXQnY-0002TG-NL for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 12:26:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXQm3-0001f3-2M for emacs-devel@gnu.org; Mon, 04 Oct 2021 12:25:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXQlz-0007Ki-AE for emacs-devel@gnu.org; Mon, 04 Oct 2021 12:25:06 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A211D440472; Mon, 4 Oct 2021 12:25:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4EE1C44038F; Mon, 4 Oct 2021 12:24:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633364699; bh=9AYI5DycWA9iy0AsPq14LhZc65fwYr2Zje5LXp4dn2M=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TLIpQQ5vR31yxq/82weip3pjXBALditnKh60kMGY+mQi8UxqVN1/+XVyhuWrD8Abj mphq4BiXoZc7J9esAaSPOhDFKaaXwsHb497I3Iv3ZKKMkHfuihieGnbD2GX6iqhdIo jm5g73UCJcn4nC0SvV5P0s9ipoN6lWLQofrFA4oJlzHM59lwxIQVuJsiGJfiXB449W QtFAF4Le491iNVbFpttdgI3KEXGtjuD0ktuPkQgcDS5C4ISN4dpzx7hnV7RGfhS8ky VqDncNXckuPAQ05C6Cdps0u257xrZK7+kVDtprSm5dk0ONVS5c3pJ84tnl0ig6LJys KZ7kz9qOCYNew== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 42D71120351; Mon, 4 Oct 2021 12:24:59 -0400 (EDT) In-Reply-To: (Arthur Miller's message of "Mon, 04 Oct 2021 17:20:28 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276226 Archived-At: > I have seen that internal code in debug.el uses advice > 'debug--implement-debug-on-entry' for instrumented symbols, but I am not sure if > it can be used as a stable check long-term. Suggested patch uses it, but if it > is considered internal and subject of change, please add a way to have a stable > predicate. Can you give us a concrete use case? Stefan