From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Remove all existing file notification watches from Emacs Date: Sat, 16 Oct 2021 09:23:30 -0400 Message-ID: References: <87zgr9igqe.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3432"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 16 15:24:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbjg1-0000dJ-8K for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 15:24:41 +0200 Original-Received: from localhost ([::1]:53174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbjfz-0000re-AN for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 09:24:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbjf8-00008A-PH for emacs-devel@gnu.org; Sat, 16 Oct 2021 09:23:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbjf5-0005TK-JN for emacs-devel@gnu.org; Sat, 16 Oct 2021 09:23:45 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9995344079E; Sat, 16 Oct 2021 09:23:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3FDD5440759; Sat, 16 Oct 2021 09:23:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634390619; bh=GJmUzN2MoywHmIK2IuviHixo9c+spoG5WAK99gGkqCw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gKS1D2WBQ0zQZ631+TiELXpBJmFEE+svobXr2zFJgRtVWrm0I4aMhNsl2KtnPFABi yNdte8sysR+PTP1wNprCpHDkzo90AKFTOIRxYQsnHthcEcuex7gzE2o+DgB39PHGKO WPXA/rk6ic9kmqXtBoeUD/G06M6fBgiYPQsgGYyTndLF9Uv0UXHfd17KjgJ1TX/sm5 lrfp7RdYFff57+oCmNLakKrMzYLTtKcnbijChDNWd3fCPgEyninuA8otYyAMM1JSYI UjVq+0hZNzTBUoGHTPlIbuR1Nx0b+EcdOxtDJxeBO3QUHOBvVAS9MoJj6fg3pOKm9I 5hzchJTVz2Vjg== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E8CF712013B; Sat, 16 Oct 2021 09:23:38 -0400 (EDT) In-Reply-To: <87zgr9igqe.fsf@gmx.de> (Michael Albinus's message of "Sat, 16 Oct 2021 09:14:17 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277170 Archived-At: > While working on bug#51146, I found the following command useful, which > removes all file notification watches from an Emacs instance: > > --8<---------------cut here---------------start------------->8--- > (defun file-notify-rm-all-watches () > "Remove all existing file notification watches from Emacs." > (interactive) > (maphash > (lambda (key _value) > (file-notify-rm-watch key)) > file-notify-descriptors)) > --8<---------------cut here---------------end--------------->8--- I can see its use while debugging but I can't imagine it being of any use in real ELisp code because it's much too blunt. [ Personally I'd put a `--` in its name and/or add some blurb in the docstring explaining it's only for debugging. ] > The code is simple enough to avoid regressions. I'd like to add it to > the emacs-28 branch (plus doc), any objection? I don't see any reason why it needs to be in emacs-28. It's not a bugfix and there's no hurry. Stefan