From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master daea9b3 1/2: Read mailcaps again only when necessary Date: Mon, 01 Nov 2021 14:35:00 -0400 Message-ID: References: <20211101135344.25800.81476@vcs0.savannah.gnu.org> <20211101135346.2EBEB20B72@vcs0.savannah.gnu.org> <87tugvrerf.fsf@gnus.org> <83sfwflrox.fsf@gnu.org> <87fssfrdul.fsf@gnus.org> <83o873lrg2.fsf@gnu.org> <8735ofrdhz.fsf@gnus.org> <83lf27lp5p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30137"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , gregory@heytings.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 01 20:48:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhdIH-0007Z9-B1 for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Nov 2021 20:48:33 +0100 Original-Received: from localhost ([::1]:43762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhdIF-0001wI-CS for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Nov 2021 15:48:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhc9K-00043T-Ir for emacs-devel@gnu.org; Mon, 01 Nov 2021 14:35:17 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhc9G-00076M-Fu; Mon, 01 Nov 2021 14:35:12 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 378B810038E; Mon, 1 Nov 2021 14:35:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C3FE310000B; Mon, 1 Nov 2021 14:35:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635791703; bh=z+BDn4nvNH9psCB/KgkvD05jTQSegfYlAaphDxnfReU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Ga9uBH9EBtUy8kYKdaqCpNMDPi/o0L/yEKkDB2SLGr1GSxokkZWfri4amCS0Dax2G iu1AXimywBQT9HK0Vxi4ndm1SWvJRfSl3F/Iu7ychGwAGU0X+X7KPhNzKRkb2IL+vS 7p6BF5yadFAwm3VvGKGAQcQtrFt8ULeRiL6+nVK3hs16Hyf3cXYnhEQC5fDSbBO77w 6wylx+2r+H5x+cXXdqfPoL17wOA6OpNuq1+j84jcw8jOG8KiGES78AEbbCuL7beIeF 3+WiBn8DQ32OocEMkxt9/SzP2J4wzyF4MC6F+chaSqFm8jGmF5IhNgC0unqHByZyW+ OOOtTxCZXUdeA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 11823120304; Mon, 1 Nov 2021 14:35:03 -0400 (EDT) In-Reply-To: <83lf27lp5p.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Nov 2021 20:13:54 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278421 Archived-At: > Once again, the key for recording the time stamp is the file name you > pass, so that key must be unique, and that means file-truename. I'm not sure `file-truename` is indispensable or even desirable. E.g.: - read file ~/fileA which is a symlink to /foo/A, with `file-truename` when `file-changed-p` is called it records that /foo/A has timestamp T1. - read ~/fileB which is a normal file. When `file-changed-p` is called it records that ~/fileB has timestamp T2. - user changes ~/fileB into a symlink to /foo/A - we go and check whether ~/fileB has changed: when `file-changed-p` is called it passes it to `file-truename` before it looks up the hash-table; it then sees that it's still T1 and will say "everything good, ~/fileB hasn't changed". -- Stefan