From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 11860f8: * test/src/comp-tests.el: Eliminate byte-compiler warnings (Bug#52105). Date: Fri, 26 Nov 2021 12:27:46 -0500 Message-ID: References: <20211126165428.32132.80341@vcs0.savannah.gnu.org> <20211126165429.C9F2F20983@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stephen Gildea To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 26 18:29:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqf2N-0008HY-QA for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Nov 2021 18:29:28 +0100 Original-Received: from localhost ([::1]:44136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqf2M-0003XX-6Z for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Nov 2021 12:29:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqf0s-0001z0-7q for emacs-devel@gnu.org; Fri, 26 Nov 2021 12:27:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqf0p-0002GI-NR for emacs-devel@gnu.org; Fri, 26 Nov 2021 12:27:53 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 44328806A7; Fri, 26 Nov 2021 12:27:49 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9F2A78005D; Fri, 26 Nov 2021 12:27:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1637947667; bh=YN3DvlB8pKQ37aBclHRq8jt6Y43ozzvg4rATa8WqReQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UZZx1tvN14f0859DoV1NqNecS6a6bl9cZLsntmbr6rXubWyFL2nlVC4kB4jgEJj5H P2dgFjeuP99nCdZJI1ln5FsZg3l4DpLmI7N6SIyFGxUEnMAbJrvfi6oLKhlZbFPvDS 1Xft8Fk48qfdBRO8Zhx2onB97kPXOWWbWsem4XkOW9rVRyKIQuVJ+f4C+JxcmvslGt DJuZfgLpd1nVf91pbjtHWhwIzq4KS7JUxiDWeg42gzE00rcdOwHu0oalYqmZ1kkRio uGib/F7U4oYhFppFUbMmM8r9XAjRWxdHZUsNDXSGWmR2Q5/RoDWl87lpTnleY0H4Xt eOsHWeyYzZ/gw== Original-Received: from ceviche (modemcable124.78-161-184.mc.videotron.ca [184.161.78.124]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 49B8E120476; Fri, 26 Nov 2021 12:27:47 -0500 (EST) In-Reply-To: <20211126165429.C9F2F20983@vcs0.savannah.gnu.org> (Stephen Gildea's message of "Fri, 26 Nov 2021 11:54:29 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280266 Archived-At: > +(eval-when-compile > + (require 'cl-lib) > + (require 'comp)) > +(eval-and-compile > + (require 'comp-cstr) ;in eval-and-compile for its defstruct > + (defconst comp-test-src (ert-resource-file "comp-test-funcs.el")) > + (defconst comp-test-dyn-src (ert-resource-file "comp-test-funcs-dyn.el")) > + (defconst comp-test-pure-src (ert-resource-file "comp-test-pure.el")) > + (defconst comp-test-45603-src (ert-resource-file "comp-test-45603.el")) > + ;; Load the test code here so the compiler can check the function > + ;; names used in this file. > + (load comp-test-src nil t) > + (load comp-test-dyn-src nil t) > + (load comp-test-pure-src nil t) > + (load comp-test-45603-src nil t)) This looks pretty ugly, in my book. Were the warnings false positives or were they diagnosing real problems? The cleanup could start by moving the (require 'comp-cstr) outside of the `eval-and-compile` since toplevel `require`s are processed both at compile and run time anyway. Stefan