From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 49e06183f5 1/3: Allow REQUIRE-MATCH to be a function Date: Sun, 12 Jun 2022 09:18:32 -0400 Message-ID: References: <165484935985.12525.14065631018362412932@vcs2.savannah.gnu.org> <20220610082240.A7222C01683@vcs2.savannah.gnu.org> <87pmjfsc1v.fsf@gnus.org> <874k0rqiwh.fsf@gnus.org> <87tu8qp5hy.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34563"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Daniel Mendler To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 12 15:20:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0NW7-0008kq-FD for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Jun 2022 15:20:35 +0200 Original-Received: from localhost ([::1]:45168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0NW5-00043L-Os for ged-emacs-devel@m.gmane-mx.org; Sun, 12 Jun 2022 09:20:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0NUL-0003Hb-V2 for emacs-devel@gnu.org; Sun, 12 Jun 2022 09:18:45 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0NUJ-0001PX-4V for emacs-devel@gnu.org; Sun, 12 Jun 2022 09:18:44 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 405371001D2; Sun, 12 Jun 2022 09:18:41 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5BE2D10013B; Sun, 12 Jun 2022 09:18:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655039915; bh=hlW7jurq6gL/KM30m5oFiP3VO9+gd35H1i5xzLdrhDE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=b5Hxq/AtfW6OL8JCsJtwk+eQepwyR4trWVMM9SHXJUylm0fwLpgoPdHC4tjV2wTtH aMFr3YHpAx/TWNzPQh858FQsBsizVpfRd78YOk+kxD+9sg66VNiWDKatc9j/wwIQVk u4IBVJU4+KT35myESP9VttkY3W3bvOSTHu3dKD9VrUWNwdTZNKxNFicg8reGX2eb2h o3JOoovGPZU/mPe+fYmIta3dcF6cdqpPMIGF+7/FvjQY+Fl/2J0wFF/UmtnVjoysZ/ 1aT2Kv2pyR0HEEbA3gPdAv0VfKBygMU61vP2nutz44TjjHRzicHSIVWElN1NWMBNrZ uV4l5UUmTSzUg== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F1E45120175; Sun, 12 Jun 2022 09:18:34 -0400 (EDT) In-Reply-To: <87tu8qp5hy.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 12 Jun 2022 11:59:05 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291092 Archived-At: Lars Ingebrigtsen [2022-06-12 11:59:05] wrote: > Stefan Monnier writes: >> If you can't reproduce the default behavior, then in my book the API >> is incomplete. > A t value for REQUIRE-MATCH in a `read-file-name' context would be > `file-exists-p'? In other contexts it would require seeing whether the > string is in COLLECTION, and that's possible, too. Look at the code that is run when (functionp minibuffer-completion-confirm) is nil, and you'll see there's a lot more to do than that if you want to reproduce the behavior faithfully. Stefan